-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document current draft for iana submission #618
Conversation
Signed-off-by: Christopher Angelo Phillips <christopher.phillips@anchore.com>
Benchmark Test ResultsBenchmark results from the latest changes vs base branch
|
Signed-off-by: Christopher Angelo Phillips <christopher.phillips@anchore.com>
Signed-off-by: Christopher Angelo Phillips <christopher.phillips@anchore.com>
91da78c
to
696957f
Compare
Signed-off-by: Christopher Angelo Phillips <christopher.phillips@anchore.com>
696957f
to
d1900fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, @spiffcs! 👏
|
||
The version parameter refers to the Syft specification version in use. | ||
|
||
version = 1*DIGIT "." 1*DIGIT "." 1*DIGIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: does 1*DIGIT
only allow for values like 5
and not 50
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Question - here is the relevant text.
https://www.rfc-editor.org/rfc/rfc2045.html#section-4
I asked the reviewer if we could use x.x.x
and they said it was fine extending to M/m/p here.
MIME-VERSION in their specification does only allow for a single digit
version := "MIME-Version" ":" 1*DIGIT "." 1*DIGIT
I can follow up and see what edits we might need for the submission since this is unclear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll make a follow-up PR when I get more clarity from the governing body. As of right now, they accepted the proposal as is. Edits are welcome should this turn out to be more strict than we need for the version constraints.
* document current draft for IANA submission Signed-off-by: Christopher Angelo Phillips <christopher.phillips@anchore.com>
WIP: Ideally we can discuss this in the afternoon and have a submission by the end of the day
Signed-off-by: Christopher Angelo Phillips christopher.phillips@anchore.com