Location order on packages should consider evidence annotations when sorting #3720
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Today when sorting locations on packages we sort based on the real and access path on these objects. This is almost correct: we should additionally consider first any package annotations that exist (i.e. is this primary evidence or supporting evidence).
This PR adjusts the behavior such that all primary evidence is listed before supporting evidence.
While working on tests for this PR and a soon-to-follow on PR, it made sense to improve some of the
cmptest
options we use around location sets and license sets (which have locations on them and affect comparisons). No functional change was made here.Type of change
Checklist: