-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(golang): add license parsing from vendor dirs #3522
Conversation
098d82d
to
b153edc
Compare
Thanks! What's the state of your PR? Should I be able to test it? Forgot to check in the test fixtures... will fix tomorrow. |
Signed-off-by: Dominik Schmidt <dev@dominik-schmidt.de>
b153edc
to
b471844
Compare
Added the missing fixtures, can you approve the workflows again? |
I'm pretty new to syft (and trying to make it work in a project I'm working on), so I'm not so sure how everything is supposed to work: Without a docker image I've tried in https://github.com/owncloud/ocis the same command crashes with
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks very close -- there is one small change I'd like to see and it needs to be rebased; I could take care of this if you like.
I'd be happy if you could take over! |
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Hi @dschmidt, sorry I seem to have missed the question you posted above 🤦 :
Given this PR is doing what the question asks, I think you already know the answer. TL;DR: syft does not scan anything outside of what you tell it to scan by default and has to get specialized handling for each task as is done in this PR. I made a few tweaks to resolve conflicts. I'm impressed by how well you adhered to the existing code patterns! Thanks for the contribution 👍 |
Description
This PR adds options to parse license information from local vendor dirs as they have a slightly different structure than mod cache dirs.
Type of change
Checklist: