Perform case insensitive matching on Java License files #2235
+22
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coheigea
force-pushed
the
coheigea/case-insensitive-matching
branch
3 times, most recently
from
8f09379 to
1293f6e
Compare
spiffcs
reviewed
Oct 24, 2023
There was a problem hiding this comment.
Thanks for the PR @coheigea!
Small comment about potential consequences of the change for other consumers of the GlobMatch function. WDYT of changing this at the caller level?
Was there another reason where you saw the GlobMatch needed to be case insensitive for its other uses?
coheigea
force-pushed
the
coheigea/case-insensitive-matching
branch
3 times, most recently
from
0cf6ef2 to
bee75a7
Compare
coheigea
changed the title
Signed-off-by: Colm O hEigeartaigh <coheigea@apache.org>
coheigea
force-pushed
the
coheigea/case-insensitive-matching
branch
from
bee75a7 to
a5e397b
Compare
spiffcs
approved these changes
Oct 25, 2023
spiffcs
added
bug
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
…e#2235) Signed-off-by: Colm O hEigeartaigh <coheigea@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #2227, perform case insensitive matching in GlobMatch so that we can check all license files in a case insensitive manner.