Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quiet flag #2081

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Fix quiet flag #2081

merged 1 commit into from
Aug 31, 2023

Conversation

wagoodman
Copy link
Contributor

Currently the quiet flag is only responsive with the logger UI, but not the text UI. This PR fixes this regression.

@wagoodman
fix quiet flag
f41e4b5 
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
@wagoodman wagoodman added the bug Something isn't working label Aug 31, 2023
@wagoodman wagoodman requested a review from a team August 31, 2023 14:21
@wagoodman wagoodman self-assigned this Aug 31, 2023
@github-actions
Copy link

Benchmark Test Results

Benchmark results from the latest changes vs base branch 
goos: linux%0Agoarch: amd64%0Apkg: github.com/anchore/syft/test/integration%0Acpu: Intel(R) Xeon(R) Platinum 8171M CPU @ 2.60GHz%0A                                                              │ ./.tmp/benchmark-0b43698.txt │%0A                                                              │            sec/op            │%0AImagePackageCatalogers/alpmdb-cataloger-2                                       15.02m ±  5%25%0AImagePackageCatalogers/apkdb-cataloger-2                                        868.0µ ±  1%25%0AImagePackageCatalogers/binary-cataloger-2                                       252.9µ ±  2%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                       725.2µ ±  4%25%0AImagePackageCatalogers/dotnet-portable-executable-cataloger-2                   26.68µ ±  4%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                             110.8µ ±  2%25%0AImagePackageCatalogers/java-cataloger-2                                         25.29m ±  2%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                         106.5µ ±  2%25%0AImagePackageCatalogers/javascript-package-cataloger-2                           460.6µ ±  4%25%0AImagePackageCatalogers/nix-store-cataloger-2                                    329.0µ ±  3%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                       954.6µ ±  4%25%0AImagePackageCatalogers/portage-cataloger-2                                      598.7µ ± 12%25%0AImagePackageCatalogers/python-package-cataloger-2                               4.072m ±  2%25%0AImagePackageCatalogers/r-package-cataloger-2                                    237.5µ ±  1%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                       646.1µ ±  3%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                                 1.113m ±  4%25%0AImagePackageCatalogers/sbom-cataloger-2                                         140.9µ ±  2%25%0Ageomean                                                                         598.4µ%0A%0A                                                              │ ./.tmp/benchmark-0b43698.txt │%0A                                                              │             B/op             │%0AImagePackageCatalogers/alpmdb-cataloger-2                                       5.135Mi ± 0%25%0AImagePackageCatalogers/apkdb-cataloger-2                                        184.5Ki ± 0%25%0AImagePackageCatalogers/binary-cataloger-2                                       30.77Ki ± 0%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                       141.4Ki ± 0%25%0AImagePackageCatalogers/dotnet-portable-executable-cataloger-2                   3.695Ki ± 0%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                             9.891Ki ± 0%25%0AImagePackageCatalogers/java-cataloger-2                                         3.388Mi ± 0%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                         8.594Ki ± 0%25%0AImagePackageCatalogers/javascript-package-cataloger-2                           83.82Ki ± 0%25%0AImagePackageCatalogers/nix-store-cataloger-2                                    38.93Ki ± 0%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                       155.3Ki ± 0%25%0AImagePackageCatalogers/portage-cataloger-2                                      109.8Ki ± 0%25%0AImagePackageCatalogers/python-package-cataloger-2                               986.2Ki ± 0%25%0AImagePackageCatalogers/r-package-cataloger-2                                    42.90Ki ± 0%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                       170.9Ki ± 0%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                                 123.2Ki ± 0%25%0AImagePackageCatalogers/sbom-cataloger-2                                         14.20Ki ± 0%25%0Ageomean                                                                         93.58Ki%0A%0A                                                              │ ./.tmp/benchmark-0b43698.txt │%0A                                                              │          allocs/op           │%0AImagePackageCatalogers/alpmdb-cataloger-2                                        88.07k ± 0%25%0AImagePackageCatalogers/apkdb-cataloger-2                                         4.034k ± 0%25%0AImagePackageCatalogers/binary-cataloger-2                                         866.0 ± 0%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                        2.911k ± 0%25%0AImagePackageCatalogers/dotnet-portable-executable-cataloger-2                     132.0 ± 0%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                               280.0 ± 0%25%0AImagePackageCatalogers/java-cataloger-2                                          44.28k ± 0%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                           228.0 ± 0%25%0AImagePackageCatalogers/javascript-package-cataloger-2                            1.264k ± 0%25%0AImagePackageCatalogers/nix-store-cataloger-2                                      820.0 ± 0%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                        3.845k ± 0%25%0AImagePackageCatalogers/portage-cataloger-2                                       2.194k ± 0%25%0AImagePackageCatalogers/python-package-cataloger-2                                16.13k ± 0%25%0AImagePackageCatalogers/r-package-cataloger-2                                      851.0 ± 0%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                        3.914k ± 0%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                                  2.291k ± 0%25%0AImagePackageCatalogers/sbom-cataloger-2                                           394.0 ± 0%25%0Ageomean                                                                          2.009k

@wagoodman wagoodman marked this pull request as ready for review August 31, 2023 14:40
@wagoodman wagoodman merged commit 36d794f into main Aug 31, 2023
@wagoodman wagoodman deleted the fix-quiet-flag branch August 31, 2023 14:40
@Porkepix Porkepix mentioned this pull request Aug 31, 2023
Merged
This was referenced Sep 1, 2023
Merged
Closed
Closed
Closed
This was referenced Sep 12, 2023
Closed
Open
Open
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@wagoodman
fix quiet flag (anchore#2081)
4119be2 
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willmurphyscode willmurphyscode willmurphyscode approved these changes

Assignees

@wagoodman wagoodman

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wagoodman @willmurphyscode