Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version notice only showing the version and no text #2042

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

wagoodman
Copy link
Contributor

Just like in anchore/grype#1445 , Currently when running grype and there is a new version available the version is shown with no other context. This PR addresses this by filling in the notice text.

@wagoodman wagoodman added the bug Something isn't working label Aug 18, 2023
@wagoodman wagoodman requested a review from a team August 18, 2023 17:40
@wagoodman wagoodman force-pushed the fix-new-version-notice branch from 7925b01 to f980840 Compare August 18, 2023 17:42
@github-actions
Copy link

github-actions bot commented Aug 18, 2023

Benchmark Test Results

Benchmark results from the latest changes vs base branch
goos: linux%0Agoarch: amd64%0Apkg: github.com/anchore/syft/test/integration%0Acpu: Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz%0A                                                              │ ./.tmp/benchmark-c614d16.txt │%0A                                                              │            sec/op            │%0AImagePackageCatalogers/alpmdb-cataloger-2                                       16.76m ±  9%25%0AImagePackageCatalogers/apkdb-cataloger-2                                        1.007m ±  9%25%0AImagePackageCatalogers/binary-cataloger-2                                       285.4µ ±  2%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                       890.6µ ±  4%25%0AImagePackageCatalogers/dotnet-portable-executable-cataloger-2                   30.90µ ±  6%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                             147.9µ ±  3%25%0AImagePackageCatalogers/java-cataloger-2                                         18.42m ±  7%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                         144.8µ ±  3%25%0AImagePackageCatalogers/javascript-package-cataloger-2                           595.0µ ±  5%25%0AImagePackageCatalogers/nix-store-cataloger-2                                    436.5µ ±  5%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                       1.179m ± 14%25%0AImagePackageCatalogers/portage-cataloger-2                                      716.4µ ±  7%25%0AImagePackageCatalogers/python-package-cataloger-2                               4.596m ±  4%25%0AImagePackageCatalogers/r-package-cataloger-2                                    332.7µ ± 13%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                       774.0µ ±  3%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                                 1.317m ±  2%25%0AImagePackageCatalogers/sbom-cataloger-2                                         164.9µ ±  2%25%0Ageomean                                                                         709.8µ%0A%0A                                                              │ ./.tmp/benchmark-c614d16.txt │%0A                                                              │             B/op             │%0AImagePackageCatalogers/alpmdb-cataloger-2                                       5.143Mi ± 0%25%0AImagePackageCatalogers/apkdb-cataloger-2                                        205.7Ki ± 0%25%0AImagePackageCatalogers/binary-cataloger-2                                       30.46Ki ± 0%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                       172.5Ki ± 0%25%0AImagePackageCatalogers/dotnet-portable-executable-cataloger-2                   3.695Ki ± 0%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                             9.906Ki ± 0%25%0AImagePackageCatalogers/java-cataloger-2                                         2.823Mi ± 0%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                         8.594Ki ± 0%25%0AImagePackageCatalogers/javascript-package-cataloger-2                           94.23Ki ± 0%25%0AImagePackageCatalogers/nix-store-cataloger-2                                    49.32Ki ± 0%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                       186.5Ki ± 0%25%0AImagePackageCatalogers/portage-cataloger-2                                      120.2Ki ± 0%25%0AImagePackageCatalogers/python-package-cataloger-2                               1.003Mi ± 0%25%0AImagePackageCatalogers/r-package-cataloger-2                                    53.30Ki ± 0%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                       181.3Ki ± 0%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                                 144.0Ki ± 0%25%0AImagePackageCatalogers/sbom-cataloger-2                                         14.20Ki ± 0%25%0Ageomean                                                                         100.5Ki%0A%0A                                                              │ ./.tmp/benchmark-c614d16.txt │%0A                                                              │          allocs/op           │%0AImagePackageCatalogers/alpmdb-cataloger-2                                        88.14k ± 0%25%0AImagePackageCatalogers/apkdb-cataloger-2                                         4.190k ± 0%25%0AImagePackageCatalogers/binary-cataloger-2                                         848.0 ± 0%25%0AImagePackageCatalogers/dpkgdb-cataloger-2                                        3.145k ± 0%25%0AImagePackageCatalogers/dotnet-portable-executable-cataloger-2                     132.0 ± 0%25%0AImagePackageCatalogers/go-module-binary-cataloger-2                               281.0 ± 0%25%0AImagePackageCatalogers/java-cataloger-2                                          40.63k ± 0%25%0AImagePackageCatalogers/graalvm-native-image-cataloger-2                           228.0 ± 0%25%0AImagePackageCatalogers/javascript-package-cataloger-2                            1.342k ± 0%25%0AImagePackageCatalogers/nix-store-cataloger-2                                      898.0 ± 0%25%0AImagePackageCatalogers/php-composer-installed-cataloger-2                        4.079k ± 0%25%0AImagePackageCatalogers/portage-cataloger-2                                       2.272k ± 0%25%0AImagePackageCatalogers/python-package-cataloger-2                                16.45k ± 0%25%0AImagePackageCatalogers/r-package-cataloger-2                                      929.0 ± 0%25%0AImagePackageCatalogers/rpm-db-cataloger-2                                        3.992k ± 0%25%0AImagePackageCatalogers/ruby-gemspec-cataloger-2                                  2.447k ± 0%25%0AImagePackageCatalogers/sbom-cataloger-2                                           394.0 ± 0%25%0Ageomean                                                                          2.063k

Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants