in directory indexer, handle outside symlinks #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Avi Deitcher <avi@deitcher.net>
kzantow
reviewed
Jun 5, 2023
Comment on lines
+373
to
+378
| // if the target path does not exist, then do not report it as a new root, or try to send | ||
| // syft parsing there. | ||
| if _, err := os.Stat(targetAbsPath); err != nil && errors.Is(err, os.ErrNotExist) { | ||
| log.Debugf("link %s points to unresolved path %s, ignoring target as new root", p, targetAbsPath) | ||
| targetAbsPath = "" | ||
| } |
There was a problem hiding this comment.
Looking how this is used, what if this was moved above, to line 337 and behaved similar to when os.ReadLink fails? e.g.:
if _, err := os.Stat(targetAbsPath); err != nil && errors.Is(err, os.ErrNotExist) {
return "", fmt.Errorf("link %s points to unresolved path %s", p, targetAbsPath)
}There was a problem hiding this comment.
I don't think so. In that case, it would return an error, when that isn't actually what we want. A symlink might be invalid now, but the file could appear later. Think of a link to a mount in a container, or to a log file that will be created later.
The symlink itself not existing, or being unreadable, is an error; the target not existing is a hanging symlink, which is fine.
kzantow
approved these changes
Jun 5, 2023
This was referenced Jun 14, 2023
Merged
Closed
This was referenced Jun 26, 2023
Closed
This was referenced Jul 3, 2023
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Signed-off-by: Avi Deitcher <avi@deitcher.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1860
Ensures that if a symlink in a directory points to something that does not exist, it logs a debug message and continues, rather than adding a new root which does not exist, which would cause a fatal error.