chore: migrate configuration to fangs #1775
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith Zantow <kzantow@gmail.com>
kzantow
commented
May 2, 2023
| @@ -35,7 +35,7 @@ require ( | |||
| github.com/spf13/afero v1.9.5 | |||
| github.com/spf13/cobra v1.7.0 | |||
| github.com/spf13/pflag v1.0.5 | |||
| github.com/spf13/viper v1.15.0 | |||
| github.com/spf13/viper v1.15.0 // indirect | |||
kzantow
commented
May 2, 2023
wagoodman
approved these changes
May 8, 2023
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates Syft to use the new fangs library to handle an aspect of configuration concerns -- integrating Cobra and Viper. This has a few immediate benefits:
SYFT_OUTPUT=json syft alpine:latest -o tabledoes not work as expected)This is related to #558, a path towards Syft 1.0