chore: add more detail on SPDX file IDs #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith Zantow <kzantow@gmail.com>
Signed-off-by: Keith Zantow <kzantow@gmail.com>
wagoodman
approved these changes
May 2, 2023
spiffcs
added a commit
that referenced
this pull request
May 4, 2023
* main: chore(docs): Update lists of catalogers (#1780) chore: add more detail on SPDX file IDs (#1769) Search /usr/share for rpmdb to fix scan on ostree-managed images (#1756) chore(deps): bump github.com/docker/docker (#1767) rename sbom.PackageCatalog to sbom.Packages (#1773) chore(deps): bump modernc.org/sqlite from 1.22.0 to 1.22.1 (#1768) Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
This was referenced May 8, 2023
Merged
Closed
This was referenced May 22, 2023
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts how Syft outputs SPDX IDs for files to include some information about the file name in the ID (up to 40 characters). This helps with SPDX Tag Value stability, as the
spdx/tools-golanglibrary is re-sorting files based on the SPDX ID. The sorting is an issue because layer hashes contribute to the file hashes themselves, so rebuilding a container and re-scanning results in significantly different ordering of the files without this change. This also helps to make relationships more clear when just looking at the SPDX relationship elements, these now includeFile-<some-path>, e.g.: