Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update golang to 1.19 #1526

Merged
merged 3 commits into from
Jan 31, 2023
Merged

feat: update golang to 1.19 #1526

merged 3 commits into from
Jan 31, 2023

Conversation

bradleyjones
Copy link
Member

Go 1.18 will become EOL with the upcoming release of Go 1.20

Signed-off-by: Bradley Jones <bradley.jones@anchore.com>
@github-actions
Copy link

github-actions bot commented Jan 31, 2023

Benchmark Test Results

Benchmark results from the latest changes vs base branch
goos: linux
goarch: amd64
pkg: github.com/anchore/syft/test/integration
cpu: Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
                                                          │ ./.tmp/benchmark-4d8828e.txt │
                                                          │            sec/op            │
ImagePackageCatalogers/alpmdb-cataloger-2                                   12.28m ± 19%
ImagePackageCatalogers/ruby-gemspec-cataloger-2                             1.314m ±  1%
ImagePackageCatalogers/python-package-cataloger-2                           3.414m ±  1%
ImagePackageCatalogers/php-composer-installed-cataloger-2                   1.110m ±  3%
ImagePackageCatalogers/javascript-package-cataloger-2                       799.9µ ±  2%
ImagePackageCatalogers/dpkgdb-cataloger-2                                   906.4µ ±  2%
ImagePackageCatalogers/rpm-db-cataloger-2                                   1.344m ±  2%
ImagePackageCatalogers/java-cataloger-2                                     14.87m ±  2%
ImagePackageCatalogers/graalvm-native-image-cataloger-2                     7.403µ ±  5%
ImagePackageCatalogers/apkdb-cataloger-2                                    912.6µ ±  1%
ImagePackageCatalogers/go-module-binary-cataloger-2                         16.66µ ±  2%
ImagePackageCatalogers/dotnet-deps-cataloger-2                              1.407m ±  1%
ImagePackageCatalogers/portage-cataloger-2                                  747.0µ ±  1%
ImagePackageCatalogers/sbom-cataloger-2                                     4.738m ±  1%
ImagePackageCatalogers/binary-cataloger-2                                   6.554m ±  2%
geomean                                                                     1.082m

                                                          │ ./.tmp/benchmark-4d8828e.txt │
                                                          │             B/op             │
ImagePackageCatalogers/alpmdb-cataloger-2                                   5.035Mi ± 0%
ImagePackageCatalogers/ruby-gemspec-cataloger-2                             205.3Ki ± 0%
ImagePackageCatalogers/python-package-cataloger-2                           955.3Ki ± 0%
ImagePackageCatalogers/php-composer-installed-cataloger-2                   217.8Ki ± 0%
ImagePackageCatalogers/javascript-package-cataloger-2                       158.2Ki ± 0%
ImagePackageCatalogers/dpkgdb-cataloger-2                                   200.2Ki ± 0%
ImagePackageCatalogers/rpm-db-cataloger-2                                   299.9Ki ± 0%
ImagePackageCatalogers/java-cataloger-2                                     3.305Mi ± 0%
ImagePackageCatalogers/graalvm-native-image-cataloger-2                     1.375Ki ± 0%
ImagePackageCatalogers/apkdb-cataloger-2                                    181.8Ki ± 0%
ImagePackageCatalogers/go-module-binary-cataloger-2                         2.121Ki ± 0%
ImagePackageCatalogers/dotnet-deps-cataloger-2                              378.0Ki ± 0%
ImagePackageCatalogers/portage-cataloger-2                                  137.9Ki ± 0%
ImagePackageCatalogers/sbom-cataloger-2                                     725.5Ki ± 0%
ImagePackageCatalogers/binary-cataloger-2                                   1.029Mi ± 0%
geomean                                                                     221.3Ki

                                                          │ ./.tmp/benchmark-4d8828e.txt │
                                                          │          allocs/op           │
ImagePackageCatalogers/alpmdb-cataloger-2                                    85.84k ± 0%
ImagePackageCatalogers/ruby-gemspec-cataloger-2                              4.349k ± 0%
ImagePackageCatalogers/python-package-cataloger-2                            16.79k ± 0%
ImagePackageCatalogers/php-composer-installed-cataloger-2                    5.604k ± 0%
ImagePackageCatalogers/javascript-package-cataloger-2                        3.432k ± 0%
ImagePackageCatalogers/dpkgdb-cataloger-2                                    4.575k ± 0%
ImagePackageCatalogers/rpm-db-cataloger-2                                    8.318k ± 0%
ImagePackageCatalogers/java-cataloger-2                                      58.65k ± 0%
ImagePackageCatalogers/graalvm-native-image-cataloger-2                       32.00 ± 0%
ImagePackageCatalogers/apkdb-cataloger-2                                     5.331k ± 0%
ImagePackageCatalogers/go-module-binary-cataloger-2                           70.00 ± 0%
ImagePackageCatalogers/dotnet-deps-cataloger-2                               7.206k ± 0%
ImagePackageCatalogers/portage-cataloger-2                                   3.683k ± 0%
ImagePackageCatalogers/sbom-cataloger-2                                      25.34k ± 0%
ImagePackageCatalogers/binary-cataloger-2                                    36.81k ± 0%
geomean                                                                      5.330k

@spiffcs
Copy link
Contributor

spiffcs commented Jan 31, 2023

Running the checks locally now to see what else might need an upgrade - thanks for the PR @bradleyjones!

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
@spiffcs spiffcs merged commit cdac224 into main Jan 31, 2023
@spiffcs spiffcs deleted the go-update branch January 31, 2023 16:39
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
* feat: update golang to 1.19

Signed-off-by: Bradley Jones <bradley.jones@anchore.com>

* chore: break out json schema drift check into separate script

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>

* chore: update git index refresh

Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>

---------

Signed-off-by: Bradley Jones <bradley.jones@anchore.com>
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants