Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor basic CPE functionality to its own package #1436

Merged
merged 2 commits into from
Jan 4, 2023
Merged

chore: refactor basic CPE functionality to its own package #1436

merged 2 commits into from
Jan 4, 2023

Conversation

kzantow
Copy link
Contributor

@kzantow kzantow commented Jan 4, 2023

This PR refactors the basic CPE structures and functionality into a top-level syft/cpe package. Namely these files (with minor renames/etc.) from syft/pkg:

cpe/
  by_specificity.go
  by_specificity_test.go
  cpe.go
  cpe_test.go
  merge_cpes.go
  merge_cpes_test.go

This is related to #558

kzantow added 2 commits January 4, 2023 10:50
@kzantow
chore: refactor basic CPE functionality to its own package
ab409af 
Signed-off-by: Keith Zantow <kzantow@gmail.com>
@kzantow
chore: move cpe test fixture data
cb471e2 
Signed-off-by: Keith Zantow <kzantow@gmail.com>
@kzantow kzantow requested a review from a team January 4, 2023 16:14
@kzantow kzantow merged commit 64be0a1 into anchore:main Jan 4, 2023
@kzantow kzantow deleted the chore/refactor-cpes branch January 4, 2023 16:26
@kzantow kzantow added enhancement New feature or request breaking-change Change is not backwards compatible labels Jan 4, 2023
This was referenced Jan 4, 2023
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 13, 2023
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@kzantow
chore: refactor basic CPE functionality to its own package (anchore#1436
0a3c004 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wagoodman wagoodman wagoodman approved these changes

Assignees
No one assigned
Labels
breaking-change Change is not backwards compatible enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kzantow @wagoodman