Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add purls for binary classifiers #1435

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Add purls for binary classifiers #1435

merged 1 commit into from
Jan 4, 2023

Conversation

noqcks
Copy link
Contributor

@noqcks noqcks commented Jan 3, 2023 •
edited
Loading

I noticed that purls were empty for binary matched packages

  {
      "id": "42128c6f2809fa6c",
      "name": "go",
      "version": "1.19.4",
      "type": "binary",
      "foundBy": "binary-cataloger",
      ...
      "purl": "",
      ...
  },

And after

  {
     "id": "42128c6f2809fa6c",
     "name": "go",
     "version": "1.19.4",
     "type": "binary",
     "foundBy": "binary-cataloger",
     ...
     "purl": "pkg:generic/go@1.19.4",
     ...
  },

Reference: purl-spec generic type

cc: @kzantow

@noqcks
adding purl types for binary classifiers
3d97683 
Signed-off-by: Benji Visser <benji@093b.org>
@noqcks noqcks mentioned this pull request Jan 4, 2023
Merged
kzantow
kzantow approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@kzantow kzantow merged commit bc1edb9 into anchore:main Jan 4, 2023
This was referenced Jan 4, 2023
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 13, 2023
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@noqcks
adding purl types for binary classifiers (anchore#1435)
b00a390 
Signed-off-by: Benji Visser <benji@093b.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzantow kzantow kzantow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noqcks @kzantow