Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add jfrog builds and tests #187

Merged
merged 10 commits into from
Sep 19, 2024
Merged

feat: add jfrog builds and tests #187

merged 10 commits into from
Sep 19, 2024

Conversation

gpongelli
Copy link
Contributor

@gpongelli gpongelli commented Sep 10, 2024 •
edited
Loading

Description

This MR adds JFrog build managements to the package.

closes #166

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has it been tested ?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • pytest suite with new tests added
  • manual test on live JFrog installation

Checklist:

  • My PR is ready for prime time! Otherwise use the "Draft PR" feature
  • All commits have a correct title
  • Readme has been updated
  • Quality tests are green (see Codacy)
  • Automated tests are green (see pipeline)

@anancarv
Copy link
Owner

Hey @gpongelli, thanks for your contribution. I'll review it asap

anancarv
anancarv requested changes Sep 16, 2024
View reviewed changes
pyartifactory/objects/build.py Outdated Show resolved Hide resolved
pyartifactory/objects/build.py Outdated Show resolved Hide resolved
pyartifactory/objects/build.py Outdated Show resolved Hide resolved
pyartifactory/models/build.py Outdated Show resolved Hide resolved
pyartifactory/objects/build.py Outdated Show resolved Hide resolved
pyartifactory/objects/build.py Outdated Show resolved Hide resolved
pyartifactory/objects/build.py Outdated Show resolved Hide resolved
pyartifactory/objects/build.py Outdated Show resolved Hide resolved
pyartifactory/objects/build.py Outdated Show resolved Hide resolved
@gpongelli
Copy link
Contributor Author

Hi @anancarv , thanks for this deep review, I'll do changes next days.

@anancarv
Copy link
Owner

Also, can you please update the README with a new section builds?

anancarv
anancarv requested changes Sep 17, 2024
View reviewed changes
pyartifactory/objects/build.py Show resolved Hide resolved
pyartifactory/models/build.py Show resolved Hide resolved
pyartifactory/objects/build.py Outdated Show resolved Hide resolved
pyartifactory/objects/build.py Outdated Show resolved Hide resolved
pyartifactory/objects/build.py Outdated Show resolved Hide resolved
anancarv
anancarv reviewed Sep 17, 2024
View reviewed changes
README.md Show resolved Hide resolved
anancarv
anancarv reviewed Sep 17, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
anancarv
anancarv reviewed Sep 17, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@gpongelli
Copy link
Contributor Author

failing tests are not related to test_build.py

@anancarv
Copy link
Owner

anancarv commented Sep 18, 2024 •
edited
Loading

failing tests are not related to test_build.py

Yes don't worry about the tests. They're failing because of codacy. Let me have a final check of the code changes before approving.

anancarv
anancarv requested changes Sep 18, 2024
View reviewed changes
Copy link
Owner

@anancarv anancarv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're almost there. There are just a few things to change on the tests

tests/test_build.py Show resolved Hide resolved
tests/test_build.py Show resolved Hide resolved
tests/test_build.py Show resolved Hide resolved
tests/test_build.py Show resolved Hide resolved
anancarv
anancarv approved these changes Sep 19, 2024
View reviewed changes
Copy link
Owner

@anancarv anancarv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm ! Thanks for your huge contribution @gpongelli

@anancarv anancarv merged commit cdb5096 into anancarv:master Sep 19, 2024
1 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anancarv anancarv anancarv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Builds API missing
2 participants
@gpongelli @anancarv