Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-plugin-angular): disable type checking diagnostics by default #1552

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

brandonroberts
Copy link
Member

PR Checklist

Closes #1551

What is the new behavior?

  • Type checking diagnostics were added and enabled by default, which could break existing apps. The type checking is disabled in the plugin by default, and enabled in the platform plugin for apps.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Jan 11, 2025

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 4721a75
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/6782e4c6776b8c000848d0a9
😎 Deploy Preview https://deploy-preview-1552--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 11, 2025

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 4721a75
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/6782e4c6963a720008a21391
😎 Deploy Preview https://deploy-preview-1552--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 11, 2025

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 4721a75
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/6782e4c69e2e170008b751ed
😎 Deploy Preview https://deploy-preview-1552--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 11, 2025

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit 4721a75
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/6782e4c6eb43fd0008ca47aa
😎 Deploy Preview https://deploy-preview-1552--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts merged commit 2945ea8 into beta Jan 11, 2025
23 of 24 checks passed
@brandonroberts brandonroberts deleted the fix-plugin-type-checking branch January 11, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vite-plugin-angular] typechecking issue in v1.12.0
1 participant