Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vitest-angular): introduce application bundle-based Vitest builder #1443

Merged
merged 9 commits into from
Dec 2, 2024

Conversation

brandonroberts
Copy link
Member

@brandonroberts brandonroberts commented Nov 15, 2024

PR Checklist

Closes #

What is the new behavior?

  • This introduces a build-test builder that uses the application builder function internally to compile the Angular files before running the tests with Vitest.
  • This builder more closely mimics the behavior of the Angular Karma Builder by bundling the files first.
  • This builder does not need a vite.config.mts file unless further customization is needed.
  • This can be a drop-in replacement for @analogjs/vitest-angular:test in the future.
    "test": {
      "executor": "@analogjs/vitest-angular:build-test",
      "options": {
        "tsConfig": "libs/my-lib/tsconfig.spec.json",
        "setupFile": "libs/my-lib/src/test-setup.ts"
      }
    },
  • The current test builder can be used with the @analogjs/vite-plugin-angular plugin which has its own internal compilation process using the Angular Compiler directly.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for analog-blog ready!

Name Link
🔨 Latest commit 9c8ce4a
🔍 Latest deploy log https://app.netlify.com/sites/analog-blog/deploys/674dd92c0f37b10008250f07
😎 Deploy Preview https://deploy-preview-1443--analog-blog.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for analog-app ready!

Name Link
🔨 Latest commit 9c8ce4a
🔍 Latest deploy log https://app.netlify.com/sites/analog-app/deploys/674dd92c53134d0008a13b15
😎 Deploy Preview https://deploy-preview-1443--analog-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for analog-docs ready!

Name Link
🔨 Latest commit 9c8ce4a
🔍 Latest deploy log https://app.netlify.com/sites/analog-docs/deploys/674dd92c7992830008dc7794
😎 Deploy Preview https://deploy-preview-1443--analog-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for analog-ng-app ready!

Name Link
🔨 Latest commit 9c8ce4a
🔍 Latest deploy log https://app.netlify.com/sites/analog-ng-app/deploys/674dd92ca1447c0008fd4054
😎 Deploy Preview https://deploy-preview-1443--analog-ng-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@samir247247
Copy link

nice ok lol

@pumano
Copy link

pumano commented Nov 30, 2024

would love to test it when it will be released

@brandonroberts brandonroberts merged commit 0bbefa0 into beta Dec 2, 2024
24 checks passed
@brandonroberts brandonroberts deleted the vitest-application-builder branch December 2, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants