Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(PeriphDrivers): Add SPI v2 support to MAX32690 #964

Merged
merged 7 commits into from
Apr 3, 2024
Merged

feat(PeriphDrivers): Add SPI v2 support to MAX32690 #964

merged 7 commits into from
Apr 3, 2024

Conversation

sihyung-maxim
Copy link
Contributor

@sihyung-maxim sihyung-maxim commented Mar 26, 2024 •
edited
Loading

Description

This PR adds SPI v2 support to MAX32690.

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

@github-actions github-actions bot added the MAX32690 Related to the MAX32690 (ME18) label Mar 26, 2024
@sihyung-maxim
Copy link
Contributor Author

The Build_Examples workflow is failing because it can't find the new SPI source files... Had this same issue when the AI87 SPI v2 dirivers were added. It doesn't seem like the runner references the PR's Libraries?

@Jake-Carter
Copy link
Contributor

The Build_Examples workflow is failing because it can't find the new SPI source files... Had this same issue when the AI87 SPI v2 dirivers were added. It doesn't seem like the runner references the PR's Libraries?

@sihyung-maxim I can replicate the error if I build PeriphDrivers for v1 and try to build the v2 example immediately afterwards. The build system doesn't know to re-build the library if settings have changed across different projects.

We worked around this with Cordio by modifying the name/filepath of the library file itself. i.e. max32655_baremetal_T2_softfp vs max32655_freertos_T1_hardfp.

I implemented this for the PeriphDrivers in 71bf46a

sihyung-maxim and others added 5 commits April 1, 2024 15:23
@sihyung-maxim @Jake-Carter
Add SPI v2 support to MAX32690
745b9f4
@sihyung-maxim @Jake-Carter
Add SPI_v2 example to ME18EVKIT
c681d40
@sihyung-maxim @Jake-Carter
Fix LED color for success/fail
3102c5d
@sihyung-maxim @Jake-Carter
Fix clang errors
95eb885
@Jake-Carter
Build PeriphDrivers SPI variants separately
2895589 
- Moves MXC_SPI_VERSION default definition to periphdriver.mk and sets
  default to 'v1'
- Set the PeriphDrivers default build folder and filename based off of
  the SPI version (ex: libPeriphDriver_spi-v1_softfp.a)
- Define MXC_SPI_V2 for v2 builds
Jake-Carter
Jake-Carter requested changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@Jake-Carter Jake-Carter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the developer note in the UG to list the devices that are currently supported by the V2 drivers?

@Jake-Carter Jake-Carter merged commit 755e6ff into main Apr 3, 2024
9 checks passed
@Jake-Carter Jake-Carter deleted the feat/me18_spiv2 branch April 3, 2024 00:54
@Jake-Carter Jake-Carter mentioned this pull request Apr 3, 2024
Open
EricB-ADI pushed a commit that referenced this pull request Aug 21, 2024
Revert "feat(PeriphDrivers): Add SPI v2 support to MAX32690 (#964)"
dfb9e26 
This reverts commit 755e6ff.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jake-Carter Jake-Carter Jake-Carter approved these changes

@lorne-maxim lorne-maxim lorne-maxim approved these changes

Assignees
No one assigned
Labels
MAX32690 Related to the MAX32690 (ME18)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sihyung-maxim @Jake-Carter @lorne-maxim