Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(PeriphDrivers): Fix MAX32690 SPI DMA RX ReqSel for SPI 2, 3, and 4 #938

Merged
merged 1 commit into from
Feb 28, 2024
Merged

fix(PeriphDrivers): Fix MAX32690 SPI DMA RX ReqSel for SPI 2, 3, and 4 #938

merged 1 commit into from
Feb 28, 2024

Conversation

Jake-Carter
Copy link
Contributor

Pull Request Template

Description

Fixes #935

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

@github-actions github-actions bot added the MAX32690 Related to the MAX32690 (ME18) label Feb 27, 2024
sihyung-maxim
sihyung-maxim approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@sihyung-maxim sihyung-maxim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange. Thought this was fixed awhile ago.

@Jake-Carter Jake-Carter merged commit 2caffd5 into analogdevicesinc:main Feb 28, 2024
7 of 8 checks passed
@Jake-Carter Jake-Carter deleted the fix/gh-935 branch February 28, 2024 01:23
@BrentK-ADI
Copy link
Contributor

Thanks @Jake-Carter !

EricB-ADI pushed a commit that referenced this pull request Aug 21, 2024
Revert "fix(PeriphDrivers): Fix MAX32690 SPI DMA RX ReqSel for SPI 2,…
283e9b1 
… 3, and 4 (#938)"

This reverts commit 2caffd5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sihyung-maxim sihyung-maxim sihyung-maxim approved these changes

Assignees
No one assigned
Labels
MAX32690 Related to the MAX32690 (ME18)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MAX32690 / ME18 - SPI DMA Bug (SPI2, 3, 4)
3 participants
@Jake-Carter @BrentK-ADI @sihyung-maxim