fix(PeriphDrivers): Fix SPI RevA1 DMA Bug When Transaction Length is Less Than the FIFO Size #905
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #879 by adding some extra logic to handle the edge case where the transaction length is less than the FIFO size. In this case, there is nothing left for the DMA to do after the FIFO is pre-loaded. The previous implementation would enable the DMA with a transfer count of 0, so the callbacks would never get triggered.
AFAIK the FIFO pre-load works around some hardware issues on some parts and is required.
Checklist Before Requesting Review