Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PeriphDrivers): Fix SPI RevA1 DMA Bug When Transaction Length is Less Than the FIFO Size #905

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

Jake-Carter
Copy link
Contributor

Description

Fixes #879 by adding some extra logic to handle the edge case where the transaction length is less than the FIFO size. In this case, there is nothing left for the DMA to do after the FIFO is pre-loaded. The previous implementation would enable the DMA with a transfer count of 0, so the callbacks would never get triggered.

AFAIK the FIFO pre-load works around some hardware issues on some parts and is required.

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

@sihyung-maxim sihyung-maxim merged commit e397bfd into analogdevicesinc:main Feb 6, 2024
8 checks passed
@Jake-Carter Jake-Carter deleted the fix/gh-879 branch February 6, 2024 22:39
EricB-ADI pushed a commit that referenced this pull request Aug 21, 2024
…ngth is Less Than the FIFO Size (#905)"

This reverts commit e397bfd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SPI RevA1 DMA Issue
2 participants