Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PeriphDrivers): Fix TMR Rev B Initialization Bug with Non-Default Clock Sources #829

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

Jake-Carter
Copy link
Contributor

@Jake-Carter Jake-Carter commented Dec 12, 2023

Description

Closes #823

There's a new note about clock selection in Rev 4 of the MAX32670 UG (See section 13.4)

image

In the past, the settings for the "A" timer were assumed to propagate through to the "B" timer in 32-bit cascade mode. It seems like there was a bug, so now we should match the clock selection for A/B on initialization to ensure proper operation in the 32-bit modes.

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

@Jake-Carter Jake-Carter changed the title fix(PeriphDrivers): Fix TMR Rev B Initialization Bug with Non-Default Clock Sources fix(PeriphDrivers): Fix TMR Rev B Initialization Bug with Non-Default Clock Sources Dec 12, 2023
@Jake-Carter Jake-Carter merged commit 5cf1338 into analogdevicesinc:main Dec 22, 2023
12 of 16 checks passed
@Jake-Carter Jake-Carter deleted the fix/gh-823 branch December 22, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAX32670 MXC_TMR_Init CTRL1_CLKSEL_A/B mismatch
2 participants