fix(PeriphDrivers): Fix MAX32655 WDT clock source order #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Order of WDT clock sources is wrong in user guide. Updated clock source order. Signed-off-by: Furkan Akkiz <hasanfurkan.akkiz@analog.com>
hfakkiz
changed the title
Jake-Carter
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Thanks @hfakkiz
You can open a Jira ticket for the User Guide here: https://jira.analog.com/projects/MBUDOCS/
I opened following ticket. |
clock_source_num parameter causes warning, fixed it. Signed-off-by: Furkan Akkiz <hasanfurkan.akkiz@analog.com>
When MSDK_NO_GPIO_CLK_INIT being defined, err variables become unused and warning occurs during build The purpose of this commit is to remove this warning Signed-off-by: Sadik Ozer <sadik.ozer@analog.com>
ozersa
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
WDT1(LPWDT0) clock sources order of MAX32655 is wrong in user guide.
To test clock source selection feature on MAX32655 for LPWDT0, selected ERTCO(CLK1) as clock source and disabled it but WDT continued to work. Switched selected clock source to CLK2 which is INRO clock's slot according to the user guide and disabled ERTCO clock, then WDT stopped working. Given clock source order in user guide is wrong. Updated clock sources order for WDT1.
Checklist Before Requesting Review