fix(BLE): Connection-Parameter-Update #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricB-ADI
changed the title
EdwinFairchild
approved these changes
Nov 21, 2023
github-actions
bot
removed
MAX32655
AbbyWolf-ADI
approved these changes
Nov 22, 2023
|
Let the record show Eric "verified" this, I was paid to approve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Cordio now will only cancel connection parameter update requests upon max attempts or connection interval agreement.
At the app layer, when requesting a connection update, a request goes through periodically until the update is successful or the max attempts have been reached. However, the stack does not differentiate between Master and Slave requests. So if the Master requests a connection update, the slaves request will be cancelled. Therefore, the parameters the application wants are never obtained. This change will stop trying for updates once the connection interval is accepted based on the range given by the user, or max attempts have been reached.