feat(MiscDrivers): Add N01S830HA Drivers for MAX78000FTHR Board #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modularize transport layer - Set burst mode for drivers to fix transactions across page boundaries - Increase SPI speed to 25Mhz - Simplify example
Jake-Carter
requested review from
Jacob-Scheiffler,
EdwinFairchild and
EricB-ADI
Jacob-Scheiffler
previously requested changes
Nov 28, 2023
| printf("(Benchmark) Wrote %i bytes to internal SRAM in %ius\n", TEST_SIZE, elapsed); | ||
|
|
||
| // Initialize test pattern | ||
| for (int i = 0; i < TEST_SIZE; i++) { |
There was a problem hiding this comment.
Initialize buffers before benchmark test and validate the test.
There was a problem hiding this comment.
Can you clarify? I just timed a single memset on the tx buffer as my benchmark
sihyung-maxim
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Closes #616
Adds drivers for the N01S830HA on-board the MAX78000FTHR to
Libraries/MiscDrivers/SRAM.The SPI transport layer is separated from the drivers, and the current implementation uses a register-level "fastspi" implementation. The "fastspi" implementation imports a "fastspi_config.h" that can be ported to different boards.
There is still some minor future work when additional SRAM drivers are added, but this one has been in the back log forever and is a good foundation.
Checklist Before Requesting Review