Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Build): Fix unrecognized option '--no-warn-rwx-segments' on riscv #793

Merged

Conversation

Jake-Carter
Copy link
Contributor

Description

For some dual-core builds on GCC 12+, the --no-warn-rwx-segments would get added to the RISC-V linker flags when the compiler doesn't support it. This PR prevents this from happening by renaming the variables to avoid namespace conflict.

Checklist Before Requesting Review

  • PR Title follows correct guidelines.
  • Description of changes and all other relevant information.
  • (Optional) Link any related GitHub issues using a keyword
  • (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

@Jake-Carter Jake-Carter merged commit 694422c into analogdevicesinc:main Nov 9, 2023
10 checks passed
@Jake-Carter Jake-Carter deleted the fix/no-warn-rwx-segments branch November 9, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants