fix(PeriphDrivers): MSDK-1242: Fix false stop detection in I2C interrupt handler #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jake-Carter
approved these changes
Oct 11, 2023
sihyung-maxim
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A customer reported that they were seeing the I2C callback function being called early when an I2C transaction with another slave device was executed before the master initiated an I2C transaction with our micro. Upon inspection it was discovered that the I2C will always assert the STOP flag when a stop condition is detected on the bus even if our micro is not the slave device involved in the I2C communication. When our micro received an address match the handler logic would think that the transaction had been completed and would immediately enter the callback function.
This PR adds a logic block to clear the STOP interrupt flag if it has been asserted as a result of a separate I2C transaction and re-arranges logic blocks in the I2C handler to avoid entering the callback function immediately after an address match.