fix(BLE): Fix PalFlashEraseSector, Decrement Erase by Sector Size

[EdwinFairchild]

Description

The PalFlashEraseSector function comments and behavior are that of a byte erase function which is incorrect. The function is called assuming size is in terms of sectors which it should be. In the function below PalFlashEraseSector is passed a value of 1 to erase one sector at a time, PalFlashEraseSector then decrements 1 -MXC_FLASH_PAGE_SIZE and causes size to underflow and the number becomes really big since it is unsigned and the function erases lots of sectors causing application to crash and be unrecoverable.

void WsfNvmEraseDataAll(WsfNvmCompEvent_t compCback)
{
  for (uint32_t eraseAddr = WSF_NVM_START_ADDR; eraseAddr < wsfNvmCb.availAddr; eraseAddr += wsfNvmCb.sectorSize) {
    PalFlashEraseSector(1, eraseAddr);
  }
  wsfNvmCb.availAddr = WSF_NVM_START_ADDR;

  if (compCback) {
    compCback(TRUE);
  }
}

Checklist Before Requesting Review

• PR Title follows correct guidelines.
• Description of changes and all other relevant information.
• (Optional) Link any related GitHub issues using a keyword
• (Optional) Provide info on any relevant functional testing/validation. For API changes or significant features, this is not optional.

[EdwinFairchild]

@yc-adi ♡