fix(CMSIS): Fix AFE_ADC_n_CTRL.ref_sel enum fields and remove deprecated registers
#1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
MAX32675
|
This pull request is stale because it has been open for 30 days with no activity. Remove stale label, commit, or comment or this will be closed in 7 days. |
|
This pull request is stale because it has been open for 30 days with no activity. Remove stale label, commit, or comment or this will be closed in 7 days. |
sihyung-maxim
requested review from
lorne-maxim and
jdk-maxim
and removed request for
lorne-maxim
|
This PR has been hanging for a while. This corrects the names and values of the affected register definitions. |
|
ok.
I'll take a look at.
Thanks,
Jeremy
…________________________________
From: Sihyung Woo ***@***.***>
Sent: Monday, September 23, 2024 3:44 PM
To: analogdevicesinc/msdk ***@***.***>
Cc: Kongs, Jeremy ***@***.***>; Review requested ***@***.***>
Subject: Re: [analogdevicesinc/msdk] fix(CMSIS): Fix `AFE_ADC_n_CTRL.ref_sel` enum fields and remove deprecated registers (PR #1069)
[External]
This PR has been hanging for a while. This corrects the names and values of the affected register definitions.
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/analogdevicesinc/msdk/pull/1069*issuecomment-2369346430__;Iw!!A3Ni8CS0y2Y!70XQosEbebRtp6wvMTOFuXUH9a-94ptPsQsMfnDwO5PCSem7CiKzLlKuMgPBRbHzHQLFGXCV78DrMyBLOSE0wrhTVgw$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ADNDREKZG37T6RP5D3ODLLTZYB4UJAVCNFSM6AAAAABKH2FZU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRZGM2DMNBTGA__;!!A3Ni8CS0y2Y!70XQosEbebRtp6wvMTOFuXUH9a-94ptPsQsMfnDwO5PCSem7CiKzLlKuMgPBRbHzHQLFGXCV78DrMyBLOSE0GIqEQ7U$>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
jdk-maxim
approved these changes
Sep 23, 2024
| @@ -563,7 +563,7 @@ extern "C" { | |||
| * @{ | |||
| */ | |||
| #define MXC_F_AFE_ADC_ZERO_PART_ID_REV_ID_POS 0 /**< PART_ID_REV_ID Position */ | |||
| #define MXC_F_AFE_ADC_ZERO_PART_ID_REV_ID ((uint32_t)(0x7UL << MXC_F_AFE_ADC_ZERO_PART_ID_REV_ID_POS)) /**< PART_ID_REV_ID Mask */ | |||
| #define MXC_F_AFE_ADC_ZERO_PART_ID_REV_ID ((uint32_t)(0x3FUL << MXC_F_AFE_ADC_ZERO_PART_ID_REV_ID_POS)) /**< PART_ID_REV_ID Mask */ | |||
There was a problem hiding this comment.
I don't think this looks right. Its only changed for 680 and only in this header file. The svd is not updated to match either, so this is likely a mistake.
There was a problem hiding this comment.
Nice catch, fixed the SVD and updated the ME16's PART_ID register. However, I think we're dropping support for the ME20, so I will leave the ME20 files as they* are to match the UG.
sihyung-maxim
pushed a commit
to analogdevicesinc/hal_adi
that referenced
this pull request
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the
AFE_ADC_n_CTRL.ref_selenumerated fields.Remove deprecated registers.
Fix #737
Checklist Before Requesting Review