Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(BLE): Updated MAX32665 libphy and fixed sys_me14 #1060

Merged
merged 2 commits into from
Jun 27, 2024
Merged

fix(BLE): Updated MAX32665 libphy and fixed sys_me14 #1060

merged 2 commits into from
Jun 27, 2024

Conversation

EricB-ADI
Copy link
Contributor

Pull Request Template

Description

  • Bump libphy max32665 to include timing fix
  • Fix MXC_SYS_GetUSN for ME14

@github-actions github-actions bot added MAX32665 Related to the MAX32665 (ME14) BLE Related to Bluetooth labels Jun 26, 2024
@EricB-ADI
Copy link
Contributor Author

/clang-format-run

@EricB-ADI EricB-ADI requested a review from yc-adi June 27, 2024 16:01
@yc-adi yc-adi merged commit dbd8bc5 into main Jun 27, 2024
1 check passed
sihyung-maxim pushed a commit to analogdevicesinc/hal_adi that referenced this pull request Jun 27, 2024
@actions-user
Update Zephyr MSDK Hal based on MSDK PR: analogdevicesinc/msdk#1060
feb441d
@Jake-Carter
Copy link
Contributor

@EricB-ADI @yc-adi attempting to build a MAX32665 BLE project with MFLOAT_ABI=hard will throw hard vs soft FP mismatch linker errors.

I opened the new libphy_hard.a file and can see -mfloat-abi=softfp was passed to the compiler. Can you regenerate the PHY with hard FP set?

@EricB-ADI
Copy link
Contributor Author

@EricB-ADI @yc-adi attempting to build a MAX32665 BLE project with MFLOAT_ABI=hard will throw hard vs soft FP mismatch linker errors.

I opened the new libphy_hard.a file and can see -mfloat-abi=softfp was passed to the compiler. Can you regenerate the PHY with hard FP set?

I fixed it in #1064. Merge the up-to-date code and recheck.

@Jake-Carter
Copy link
Contributor

@EricB-ADI thanks, links clean now

@Jake-Carter Jake-Carter deleted the fix/usn-me14 branch July 1, 2024 21:23
EricB-ADI pushed a commit that referenced this pull request Aug 21, 2024
Revert "fix(BLE): Updated MAX32665 libphy and fixed sys_me14 (#1060)"
ce3f242 
This reverts commit dbd8bc5.
ozersa pushed a commit to analogdevicesinc/hal_adi that referenced this pull request Sep 11, 2024
@actions-user @ozersa
Update Zephyr MSDK Hal based on MSDK PR: analogdevicesinc/msdk#1060
fa25841
ozersa pushed a commit to analogdevicesinc/hal_adi that referenced this pull request Sep 11, 2024
@actions-user @ozersa
Update Zephyr MSDK Hal based on MSDK PR: analogdevicesinc/msdk#1060
8214b23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yc-adi yc-adi yc-adi approved these changes

@AbbyWolf-ADI AbbyWolf-ADI Awaiting requested review from AbbyWolf-ADI

Assignees
No one assigned
Labels
BLE Related to Bluetooth MAX32665 Related to the MAX32665 (ME14)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EricB-ADI @Jake-Carter @yc-adi