Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DC2677A - LTC235x: Initial Design #1130

Merged
merged 2 commits into from
Oct 2, 2023
Merged

DC2677A - LTC235x: Initial Design #1130

merged 2 commits into from
Oct 2, 2023

Conversation

jemfgeronimo
Copy link
Contributor

@jemfgeronimo jemfgeronimo commented May 17, 2023 •
edited
Loading

@kseerp kseerp mentioned this pull request May 25, 2023
Merged
@jemfgeronimo jemfgeronimo marked this pull request as ready for review May 26, 2023 01:13
@jemfgeronimo jemfgeronimo requested a review from a team May 26, 2023 01:13
PopPaul2021
PopPaul2021 requested changes May 30, 2023
View reviewed changes
Copy link
Contributor

@PopPaul2021 PopPaul2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than updating the DC2677A HDL Reference Design Wiki page, it looks good to me!

projects/dc2677a/Readme.md Show resolved Hide resolved
projects/dc2677a/Readme.md Show resolved Hide resolved
projects/dc2677a/Readme.md Outdated Show resolved Hide resolved
IuliaCMoldovan
IuliaCMoldovan requested changes May 31, 2023
View reviewed changes
library/axi_ltc235x/axi_ltc235x.v Outdated Show resolved Hide resolved
library/axi_ltc235x/axi_ltc235x.v Show resolved Hide resolved
projects/dc2677a/c5soc/system_top.v Outdated Show resolved Hide resolved
library/axi_ltc235x/axi_ltc235x_lvds.v Outdated Show resolved Hide resolved
library/axi_ltc235x/axi_ltc235x_lvds.v Outdated Show resolved Hide resolved
library/axi_ltc235x/axi_ltc235x_cmos.v Outdated Show resolved Hide resolved
library/axi_ltc235x/axi_ltc235x_cmos.v Outdated Show resolved Hide resolved
projects/dc2677a/common/dc2677a_qsys.tcl Outdated Show resolved Hide resolved
projects/dc2677a/common/dc2677a_qsys.tcl Show resolved Hide resolved
projects/dc2677a/common/dc2677a_qsys.tcl Outdated Show resolved Hide resolved
@IuliaCMoldovan
Copy link
Contributor

Was it tested in hardware?

@CLAassistant
Copy link

CLAassistant commented Jul 17, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

IuliaCMoldovan
IuliaCMoldovan requested changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@IuliaCMoldovan IuliaCMoldovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the copyright and license header to all .tcl and .sdc files, like the changes done in these PRs #1139 and #1141.
The starting year of the copyright should be the year the project was firstly created.

projects/dc2677a/common/dc2677a_qsys.tcl Outdated Show resolved Hide resolved
library/axi_ltc235x/axi_ltc235x_cmos.v Show resolved Hide resolved
@jemfgeronimo
Copy link
Contributor Author

Linux driver merged to master
analogdevicesinc/linux#2201

@jemfgeronimo jemfgeronimo force-pushed the dev_ltc235x_dc2677a branch 3 times, most recently from c86c989 to 78dcbb6 Compare September 27, 2023 01:47
@jemfgeronimo
axi_ltc235x: Add initial design
f5859bf 
Signed-off-by: Jem Geronimo <Johnerasmusmari.Geronimo@analog.com>
@jemfgeronimo
dc2677a: add initial design
0af6a5f 
Signed-off-by: Jem Geronimo <Johnerasmusmari.Geronimo@analog.com>
PopPaul2021
PopPaul2021 approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@PopPaul2021 PopPaul2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Both CMOS and LVDS modes for LTC2358-18 were built without errors or critical warnings.

@jemfgeronimo jemfgeronimo merged commit 4abb8b3 into master Oct 2, 2023
1 of 2 checks passed
@jemfgeronimo jemfgeronimo deleted the dev_ltc235x_dc2677a branch October 2, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreiGrozav AndreiGrozav AndreiGrozav approved these changes

@IuliaCMoldovan IuliaCMoldovan IuliaCMoldovan approved these changes

@PopPaul2021 PopPaul2021 PopPaul2021 approved these changes

@acostina acostina Awaiting requested review from acostina

Assignees
No one assigned
Labels
newboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jemfgeronimo @IuliaCMoldovan @CLAassistant @AndreiGrozav @PopPaul2021