feat: only cache if the SDK is not yet cached #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyu
reviewed
Oct 6, 2023
src/cache.ts
Outdated
Comment on lines
59
to
70
| core.info(`checking if "${restoreKey}" is already cached ...`) | ||
| const hasEntry = await cache.restoreCache([ANDROID_HOME_DIR], restoreKey, [], { lookupOnly: true }) | ||
| if (hasEntry) { | ||
| core.info(`Found in cache: ${restoreKey}`) | ||
| return | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| core.info(`checking if "${restoreKey}" is already cached ...`) | |
| const hasEntry = await cache.restoreCache([ANDROID_HOME_DIR], restoreKey, [], { lookupOnly: true }) | |
| if (hasEntry) { | |
| core.info(`Found in cache: ${restoreKey}`) | |
| return | |
| } | |
| core.info(`checking if "${restoreKey}" is already cached ...`) | |
| const hasEntry = await cache.restoreCache([ANDROID_HOME_DIR], restoreKey, [], { lookupOnly: true }) | |
| if (hasEntry) { | |
| core.info(`Found in cache: ${restoreKey}`) | |
| return | |
| } | |
| core.info(`caching "${restoreKey}" ...`) | |
| return await cache.saveCache([ANDROID_HOME_DIR], restoreKey) | |
| } |
There was a problem hiding this comment.
Are you suggesting that I remove the catch on ReserveCacheError? 👌
There was a problem hiding this comment.
Yes!
I did not know how to check if the cache already exists.
So, if I did a cache and got a ReserveCacheError, it meant that the cache was already there.
|
please run |
|
and check the lint error(prettier) |
|
Thanks for your PR! |
|
https://github.com/amyu/setup-android/releases/tag/v3.3 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.