typos in 004-feature-template.md #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feng-tao
approved these changes
Oct 7, 2020
|
@paularmand could you update the DCO? thanks. |
typos Signed-off-by: Paul-Armand Verhaegen <paularmand.verhaegen@gmail.com>
|
thanks |
allisonsuarez
pushed a commit
that referenced
this pull request
Oct 20, 2020
typos Signed-off-by: Paul-Armand Verhaegen <paularmand.verhaegen@gmail.com> Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
allisonsuarez
added a commit
that referenced
this pull request
Oct 28, 2020
* started writing rfc and added dir Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * made small change on README and added more to RFC will create PR to get number now Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more content to Badges rfc Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * renamed file Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * almost done with doc Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added more context Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added Marcos's suggestion Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Update 004-feature-template.md (#6) typos Signed-off-by: Paul-Armand Verhaegen <paularmand.verhaegen@gmail.com> Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Updated RFC based on implementation Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * doc: add code owner file (#7) Signed-off-by: feng-tao <fengtao04@gmail.com> Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * oops Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * deleted duplicate Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> Co-authored-by: Paul-Armand Verhaegen <paularmand.verhaegen@gmail.com> Co-authored-by: Tao Feng <fengtao04@gmail.com>
allisonsuarez
added a commit
that referenced
this pull request
Feb 23, 2021
* started writing rfc and added dir Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * made small change on README and added more to RFC will create PR to get number now Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more content to Badges rfc Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * renamed file Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * almost done with doc Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added more context Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added Marcos's suggestion Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Update 004-feature-template.md (#6) typos Signed-off-by: Paul-Armand Verhaegen <paularmand.verhaegen@gmail.com> Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Updated RFC based on implementation Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * doc: add code owner file (#7) Signed-off-by: feng-tao <fengtao04@gmail.com> Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * oops Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * deleted duplicate Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> Co-authored-by: Paul-Armand Verhaegen <paularmand.verhaegen@gmail.com> Co-authored-by: Tao Feng <fengtao04@gmail.com> Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
allisonsuarez
added a commit
that referenced
this pull request
May 5, 2021
* started writing rfc and added dir Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * made small change on README and added more to RFC will create PR to get number now Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * more content to Badges rfc Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * renamed file Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * almost done with doc Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added more context Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * added Marcos's suggestion Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Update 004-feature-template.md (#6) typos Signed-off-by: Paul-Armand Verhaegen <paularmand.verhaegen@gmail.com> Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * Updated RFC based on implementation Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * doc: add code owner file (#7) Signed-off-by: feng-tao <fengtao04@gmail.com> Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * updated Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * oops Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> * deleted duplicate Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com> Co-authored-by: Paul-Armand Verhaegen <paularmand.verhaegen@gmail.com> Co-authored-by: Tao Feng <fengtao04@gmail.com> Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typos