Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix dashboard model errors, change deprecated pytest function #160

Merged
merged 4 commits into from
Nov 3, 2020

Conversation

Wonong
Copy link
Contributor

@Wonong Wonong commented Nov 3, 2020

Summary of Changes

  • Since the assertEquals function has been deprecated, replaced it with the assertEqual function for all test files.
  • tests/unit/api/dashboard/fixture.py: Add chart_names field to dashboard fixture since model changes in amundsencommon

Tests

Passed all existing unit tests

Documentation

pytest doc about deprecated function: https://docs.python.org/3.3/library/unittest.html#deprecated-aliases
model changes in amundsencommon: https://github.com/amundsen-io/amundsencommon/pull/73/files

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

Signed-off-by: Wonyeong Choi <ciwnyg0815@gmail.com>
Signed-off-by: Wonyeong Choi <ciwnyg0815@gmail.com>
Signed-off-by: Wonyeong Choi <ciwnyg0815@gmail.com>
…g/amundsensearchlibrary into update_deprecated_function

Signed-off-by: Wonyeong Choi <ciwnyg0815@gmail.com>
@feng-tao
Copy link
Member

feng-tao commented Nov 3, 2020

thanks!

@feng-tao feng-tao merged commit 1304234 into amundsen-io:master Nov 3, 2020
tianruzhou-db pushed a commit to tianruzhou-db/amundsensearchlibrary that referenced this pull request Jan 22, 2021
…mundsen-io#160)

* Change deprecated function assertEquals to assertEqual

Signed-off-by: Wonyeong Choi <ciwnyg0815@gmail.com>

* fix lint

Signed-off-by: Wonyeong Choi <ciwnyg0815@gmail.com>

* fix lint, add chart_names field to chart_names

Signed-off-by: Wonyeong Choi <ciwnyg0815@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants