fix: fix dashboard model errors, change deprecated pytest function #160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
assertEquals
function has been deprecated, replaced it with theassertEqual
function for all test files.tests/unit/api/dashboard/fixture.py
: Addchart_names
field to dashboard fixture since model changes inamundsencommon
Tests
Passed all existing unit tests
Documentation
pytest doc about deprecated function: https://docs.python.org/3.3/library/unittest.html#deprecated-aliases
model changes in
amundsencommon
: https://github.com/amundsen-io/amundsencommon/pull/73/filesCheckList
Make sure you have checked all steps below to ensure a timely review.
make test