refactor: use swagger for table model in search #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feng-tao
force-pushed
the
tfeng_table_swagger
branch
from
8a9dd7d to
ffce8be
Compare
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
==========================================
+ Coverage 75.20% 75.28% +0.08%
==========================================
Files 17 17
Lines 613 615 +2
Branches 76 77 +1
==========================================
+ Hits 461 463 +2
Misses 127 127
Partials 25 25
Continue to review full report at Codecov.
|
jinhyukchang
previously approved these changes
Jun 8, 2020
setup.py
Outdated
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| from setuptools import setup, find_packages | |||
|
|
|||
| __version__ = '2.3.3' | |||
| __version__ = '2.3.4rc0' | |||
There was a problem hiding this comment.
Don't forget to remove rc0
There was a problem hiding this comment.
will test on staging first :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Use swagger for table model in search to make it consistent.
Tests
What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line
Documentation
What documentation did you add or modify and why? Add any relevant links then remove this line
CheckList
Make sure you have checked all steps below to ensure a timely review.
make test