-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added programmatic description fields #104
Added programmatic description fields #104
Conversation
Added an abstract method for getting programmatic descriptions that is currently not being used. Modified _exec_table_query to return prog_descriptions as part of the TableData call Increased amundsen-common to latest version Adding a couple of todo statements
adding a couple of tests sorting alphabetically by default
…oc-round2 # Conflicts: # requirements.txt
increasing amundsen-common dependency to 0.2.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Left few comments. Let me know, @samshuster
…gging statements.
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
=========================================
Coverage ? 70.58%
=========================================
Files ? 21
Lines ? 1030
Branches ? 105
=========================================
Hits ? 727
Misses ? 277
Partials ? 26
Continue to review full report at Codecov.
|
ok i think i addressed all of your concerns @jinhyukchang! also revved minor version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, @samshuster !
Summary of Changes
amundsen-io/amundsen#147
I added the inclusion of programmatic descriptions in the returned table metadata object.
Tests
I modified the proxy-neo4j tests to test for programmatic description.
Documentation
None added.
CheckList
Make sure you have checked all steps below to ensure a timely review.
make test