Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added programmatic description fields #104

Merged

Conversation

samshuster
Copy link
Contributor

@samshuster samshuster commented Jan 28, 2020

Summary of Changes

amundsen-io/amundsen#147

I added the inclusion of programmatic descriptions in the returned table metadata object.

Tests

I modified the proxy-neo4j tests to test for programmatic description.

Documentation

None added.

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

Added an abstract method for getting programmatic descriptions that is currently not being used.
Modified _exec_table_query to return prog_descriptions as part of the TableData call
Increased amundsen-common to latest version

Adding a couple of todo statements
adding a couple of tests
sorting alphabetically by default
@samshuster samshuster changed the title WIP: Added programmatic description fields Added programmatic description fields Feb 11, 2020
increasing amundsen-common dependency to 0.2.1
jinhyukchang
jinhyukchang previously approved these changes Feb 12, 2020
Copy link
Contributor

@jinhyukchang jinhyukchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Left few comments. Let me know, @samshuster

metadata_service/proxy/neo4j_proxy.py Outdated Show resolved Hide resolved
metadata_service/proxy/neo4j_proxy.py Outdated Show resolved Hide resolved
tests/unit/api/table/test_table_detail_api.py Outdated Show resolved Hide resolved
metadata_service/proxy/neo4j_proxy.py Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Feb 13, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@5bb3b69). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #104   +/-   ##
=========================================
  Coverage          ?   70.58%           
=========================================
  Files             ?       21           
  Lines             ?     1030           
  Branches          ?      105           
=========================================
  Hits              ?      727           
  Misses            ?      277           
  Partials          ?       26
Impacted Files Coverage Δ
metadata_service/api/table.py 100% <ø> (ø)
metadata_service/api/user.py 100% <ø> (ø)
metadata_service/proxy/atlas_proxy.py 84.69% <100%> (ø)
metadata_service/proxy/gremlin_proxy.py 44.77% <100%> (ø)
metadata_service/proxy/base_proxy.py 67.27% <100%> (ø)
metadata_service/proxy/neo4j_proxy.py 73.82% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bb3b69...3e3f42b. Read the comment docs.

@samshuster
Copy link
Contributor Author

ok i think i addressed all of your concerns @jinhyukchang! also revved minor version

Copy link
Contributor

@jinhyukchang jinhyukchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, @samshuster !

@jinhyukchang jinhyukchang merged commit 29c5d57 into amundsen-io:master Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants