feat: Add support for tracking Data Issues via Asana #700
Conversation
nathanlawrence-asana
requested review from
allisonsuarez,
dikshathakur3119,
feng-tao,
Golodhros,
ttannis and
a team
as code owners
nathanlawrence-asana
force-pushed
the
nathanlawrence-asana
branch
3 times, most recently
from
4db2e0c to
1de93e1
Compare
nathanlawrence-asana
changed the title
Signed-off-by: Nathan Lawrence <nathanlawrence@asana.com>
nathanlawrence-asana
force-pushed
the
nathanlawrence-asana
branch
from
1de93e1 to
11bccd0
Compare
|
cc @allisonsuarez @ttannis @dikshathakur3119 |
There was a problem hiding this comment.
I did a basic test with this branch in our staging and everything is fine.
lgtm, @nathanlawrence-asana could you write / update the existing doc about how to use Asana for tracking data issues (e.g how to config with a basic example)? thanks
There was a problem hiding this comment.
Can you edit this doc accordingly: https://github.com/amundsen-io/amundsenfrontendlibrary/blob/master/docs/flask_config.md#issue-tracking-integration-features
| self.assertEqual(data_issue.title, self.title) | ||
| self.assertEqual(data_issue.url, self.url) | ||
| self.assertEqual(data_issue.status, self.status) | ||
| priority=self.priority).serialize() |
There was a problem hiding this comment.
Just curious why you use serialize() here.
| @@ -64,6 +64,7 @@ class Config: | |||
|
|
|||
| # Settings for Issue tracker integration | |||
| ISSUE_LABELS = [] # type: List[str] | |||
| ISSUE_TRACKER_API_TOKEN = None # type: str | |||
There was a problem hiding this comment.
Where is this used? I don't see it in the asana client, or did I miss something?
|
ping @nathanlawrence-asana let us know once you update the pr with a doc. |
|
I am going to merge the pr now. @nathanlawrence-asana let us know if you have the chance to create a doc for the new client. |
Signed-off-by: Nathan Lawrence <nathanlawrence@asana.com> Signed-off-by: dikshathakur3119 <dikshathakur3119@gmail.com>
Summary of Changes
This adds an AsanaClient alongside the existing JIRA client.
Additionally, I've refactored the JIRA priority map to be a Python Enum that includes both the JIRA priority and severity and has helper methods for creating a priority object based on those values.
Tests
I've added one basic test.
Documentation
I'll happily add documentation if folks are happy with the current state of this PR.
CheckList
Make sure you have checked all steps below to ensure a timely review.