Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Testing types for table input #699

Merged
merged 10 commits into from
Oct 2, 2020
Merged

chore: Testing types for table input #699

merged 10 commits into from
Oct 2, 2020

Conversation

Golodhros
Copy link
Member

Signed-off-by: Marcos Iglesias miglesiasvalle@lyft.com

Summary of Changes

Trying to type the table entry properly, relating the data with the columns

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes, including screenshots of any UI changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public python functions and the classes in the PR contain docstrings that explain what it does
  • PR passes all tests documented in the developer guide

@ttannis
Copy link
Contributor

ttannis commented Sep 30, 2020

Might need some more context on this one since I'm unsure what current use cases we are trying to support/make stronger typing for.

@Golodhros
Copy link
Member Author

Might need some more context on this one since I'm unsure what current use cases we are trying to support/make stronger typing for.

Basically, I am aiming for the example on the storybook to break, so if a user passes a column which key is not on the data, it should break!

Marcos Iglesias added 4 commits September 30, 2020 21:21
Testing types for table input
e0e6c65 
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Removing generic
5e4a095 
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Adds data validation to table
46c6160 
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Removing verbose Error string
0bcc23c 
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Marcos Iglesias added 2 commits September 30, 2020 21:45
Adding Gago's recommendation
47981e9 
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Cleanup and reorganization
d2b49f0 
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Marcos Iglesias added 3 commits September 30, 2020 22:12
Using a for loop
ed1b477 
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Reducing noise on tests, using some
a216744 
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
Moving editUrl and editText to null on the table
5510085 
Signed-off-by: Marcos Iglesias <miglesiasvalle@lyft.com>
@Golodhros @gagoar
Update amundsen_application/static/js/components/common/Table/index.s…
59b4482 
…pec.tsx


Signed-off-by: Marcos Iglesias Valle <golodhros@gmail.com>

Co-authored-by: Gago <xeroice@gmail.com>
allisonsuarez
allisonsuarez approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@allisonsuarez allisonsuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I like that we are getting more informative errors

@Golodhros Golodhros merged commit c632102 into master Oct 2, 2020
@ttannis ttannis deleted the mi-ts-table branch October 5, 2020 17:11
@ttannis
Copy link
Contributor

ttannis commented Oct 5, 2020

Thanks for this PR, learned some helpful patterns.

dikshathakur3119 pushed a commit that referenced this pull request Oct 15, 2020
@Golodhros
chore: Testing types for table input (#699)
c8c581a 
Signed-off-by: Marcos Iglesias Valle <golodhros@gmail.com>
Signed-off-by: dikshathakur3119 <dikshathakur3119@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gagoar gagoar gagoar left review comments

@allisonsuarez allisonsuarez allisonsuarez approved these changes

@dikshathakur3119 dikshathakur3119 Awaiting requested review from dikshathakur3119 dikshathakur3119 is a code owner

@feng-tao feng-tao Awaiting requested review from feng-tao feng-tao is a code owner

@ttannis ttannis Awaiting requested review from ttannis ttannis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Golodhros @ttannis @gagoar @allisonsuarez