Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add in Snowflake db logo #686

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Conversation

instazackwu
Copy link
Contributor

Summary of Changes

Add in a logo for Snowflake database tables

Tests

None, UI change

image
image

Documentation

None

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes, including screenshots of any UI changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public python functions and the classes in the PR contain docstrings that explain what it does
  • PR passes all tests documented in the developer guide

Signed-off-by: Zack Wu <zack.wu@instacart.com>
@instazackwu
Copy link
Contributor Author

cc @Alagappan adding in a logo for Snowflake database data

@feng-tao feng-tao changed the title other - Add in Snowflake db logo chore: Add in Snowflake db logo Sep 24, 2020
@feng-tao feng-tao merged commit 3a1b112 into amundsen-io:master Sep 24, 2020
@feng-tao
Copy link
Member

thanks @instazackwu , is Amundsen in prod now? and could you submit a pr to add your company to our user list (https://github.com/amundsen-io/amundsen#who-uses-amundsen) ? That will be super helpful, thanks!

@instazackwu
Copy link
Contributor Author

thanks @instazackwu , is Amundsen in prod now? and could you submit a pr to add your company to our user list (https://github.com/amundsen-io/amundsen#who-uses-amundsen) ? That will be super helpful, thanks!

Thanks Tao! We're making it official next week - I'll put in a PR to do that then :)

@Alagappan
Copy link
Contributor

Great! Good to see the progress @instazackwu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants