Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix docker push in FE repo #637

Merged
merged 1 commit into from
Sep 2, 2020
Merged

chore: fix docker push in FE repo #637

merged 1 commit into from
Sep 2, 2020

Conversation

feng-tao
Copy link
Member

@feng-tao feng-tao commented Sep 2, 2020

Signed-off-by: feng-tao fengtao04@gmail.com

Summary of Changes

Currently the docker push will mutate the latest tag/version docker file. Do the same change as https://github.com/amundsen-io/amundsenmetadatalibrary

Tests

What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes, including screenshots of any UI changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public python functions and the classes in the PR contain docstrings that explain what it does
  • PR passes all tests documented in the developer guide

Signed-off-by: feng-tao <fengtao04@gmail.com>
@feng-tao feng-tao requested a review from a team as a code owner September 2, 2020 05:10
@feng-tao feng-tao requested review from Golodhros and verdan and removed request for Golodhros September 2, 2020 05:11
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feng-tao feng-tao merged commit 6355e81 into master Sep 2, 2020
@feng-tao feng-tao deleted the tfeng_fix_docker branch September 2, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants