Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update 'table view', 'alumni' and SLA status badges #595

Merged
merged 29 commits into from
Aug 20, 2020
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
7350d82
removed badges section for users cause we dont need that moving forward
allisonsuarez Aug 6, 2020
dd13c8d
removed ALumni badge from user profile and added it to header-bullets…
allisonsuarez Aug 6, 2020
dcfe0c5
removed Alumni badge checks for user profiles
allisonsuarez Aug 6, 2020
2c07e1e
not working for some reason
allisonsuarez Aug 7, 2020
7c6267c
lint and missed test update
allisonsuarez Aug 7, 2020
576fdab
fixed conflict
allisonsuarez Aug 17, 2020
1e85814
updated DashboardPage tests
allisonsuarez Aug 17, 2020
522179e
added icons
allisonsuarez Aug 18, 2020
2691c23
lint
allisonsuarez Aug 18, 2020
3abea6d
fixed alignment issue
allisonsuarez Aug 18, 2020
5e1c02a
fixed table view
allisonsuarez Aug 19, 2020
c9e1668
added variables for style
allisonsuarez Aug 19, 2020
e157509
made component more genric, still need to rename and fix icon issue
allisonsuarez Aug 19, 2020
6c2c16e
updated text to use typography defined
allisonsuarez Aug 19, 2020
e2b7c1f
variable
allisonsuarez Aug 19, 2020
1823001
hit icon broken
allisonsuarez Aug 19, 2020
5ba4f1d
fixed hit icon a bit
allisonsuarez Aug 19, 2020
f4640e8
fixed tets
allisonsuarez Aug 19, 2020
d0b6e1b
moved setup into it clause
allisonsuarez Aug 19, 2020
1121cad
added resource badges back in
allisonsuarez Aug 19, 2020
c9e739f
lint + added back tests
allisonsuarez Aug 19, 2020
4d6b782
fixes
allisonsuarez Aug 19, 2020
03d0f5b
lint
allisonsuarez Aug 19, 2020
a9eb676
fixed icon for hit
allisonsuarez Aug 19, 2020
1f9e1cf
bettered updated file
allisonsuarez Aug 19, 2020
30f5cd1
removed text prop
allisonsuarez Aug 19, 2020
691d2b6
fixed text issue
allisonsuarez Aug 19, 2020
5d4a7d1
small fix
allisonsuarez Aug 19, 2020
6adc003
cleanup
allisonsuarez Aug 19, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updated text to use typography defined
Signed-off-by: Allison Suarez Miranda <asuarezmiranda@lyft.com>
allisonsuarez committed Aug 19, 2020
commit 6c2c16e4aab3320d7a8483cc53270e810b3ecf3f
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@ const MissedState: React.FC<StateProps> = ({
<div className="exclamation-top" />
<div className="exclamation-bottom" />
</div>
<span className="status-text body-2 text-primary">{stateText}</span>
<span className="status-text">{stateText}</span>
</div>
);
};
@@ -36,7 +36,7 @@ const HitState: React.FC<StateProps> = ({
<div className="hit-icon">
<img className="icon icon-check" alt="" />
</div>
<span className="status-text body-2 text-primary">{stateText}</span>
<span className="status-text">{stateText}</span>
</div>
);
};
Original file line number Diff line number Diff line change
@@ -2,6 +2,7 @@
// SPDX-License-Identifier: Apache-2.0

@import 'variables';
@import 'typography-default';

.missed-icon,
.hit-icon {
@@ -44,4 +45,5 @@
display: inline-block;
margin-left: $spacer-1;
vertical-align: middle;
@extend %text-body-w2;
}