Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the inline search bar reload on a table details page #385

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

danwom
Copy link

@danwom danwom commented Jan 29, 2020

Summary of Changes

Fix an issue where we were requesting the same table data as before.

Tests

What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes, including screenshots of any UI changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public python functions and the classes in the PR contain docstrings that explain what it does
  • PR passes all tests documented in the developer guide

@codecov-io
Copy link

codecov-io commented Jan 29, 2020

Codecov Report

Merging #385 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #385   +/-   ##
=======================================
  Coverage   75.32%   75.32%           
=======================================
  Files         168      168           
  Lines        4199     4199           
  Branches      522      522           
=======================================
  Hits         3163     3163           
  Misses       1000     1000           
  Partials       36       36
Impacted Files Coverage Δ
...ication/static/js/components/TableDetail/index.tsx 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f51902...2fc4563. Read the comment docs.

@danwom danwom requested review from feng-tao and ttannis January 29, 2020 01:09
@ttannis ttannis merged commit 42177c9 into master Jan 29, 2020
@ttannis ttannis deleted the search-bar-fix-2 branch January 30, 2020 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants