-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update profile page design #365
Conversation
Codecov Report
@@ Coverage Diff @@
## master #365 +/- ##
==========================================
+ Coverage 76.19% 76.48% +0.28%
==========================================
Files 167 167
Lines 4147 4185 +38
Branches 525 530 +5
==========================================
+ Hits 3160 3201 +41
+ Misses 950 948 -2
+ Partials 37 36 -1
Continue to review full report at Codecov.
|
- Modified behavior/style of breadcrumb
amundsen_application/static/js/components/ProfilePage/tests/index.spec.tsx
Outdated
Show resolved
Hide resolved
amundsen_application/static/js/components/ProfilePage/index.tsx
Outdated
Show resolved
Hide resolved
amundsen_application/static/js/components/TableDetail/styles.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good but I haven't been able to verify the UI changes by building locally with our usual build script and I get some error about babel-polyfill
. However when I checkout master that builds fine. I can't think of any reason why this would be the case since this makes no changes to our dependencies, but I can try to build master again after this is merged and see what happens in my environment.
.profile-avatar { | ||
display: inline-block; | ||
margin: 6px 16px 0 0; | ||
} | ||
|
||
.profile-details { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these styles no longer necessary/applicable because of header-section
styles?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, these were all for the old layout.
1 & 2 should be fixed. |
I think this specific branch doesn't have the latest updates to the NPM packages, so it's not compatible with your current version of node. (should work with node 10 or lower) |
That must have been it. Master still building fine for me with these changes. |
Summary of Changes
Update the profile page design have a similar layout as the table details page.
Tests
What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line
Documentation
What documentation did you add or modify and why? Add any relevant links then remove this line
CheckList
Make sure you have checked all steps below to ensure a timely review.