Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update profile page design #365

Merged
merged 7 commits into from
Jan 21, 2020
Merged

Update profile page design #365

merged 7 commits into from
Jan 21, 2020

Conversation

danwom
Copy link

@danwom danwom commented Jan 8, 2020

Summary of Changes

Update the profile page design have a similar layout as the table details page.

Tests

What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes, including screenshots of any UI changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public python functions and the classes in the PR contain docstrings that explain what it does
  • PR passes all tests documented in the developer guide

@codecov-io
Copy link

codecov-io commented Jan 8, 2020

Codecov Report

Merging #365 into master will increase coverage by 0.28%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
+ Coverage   76.19%   76.48%   +0.28%     
==========================================
  Files         167      167              
  Lines        4147     4185      +38     
  Branches      525      530       +5     
==========================================
+ Hits         3160     3201      +41     
+ Misses        950      948       -2     
+ Partials       37       36       -1
Impacted Files Coverage Δ
amundsen_application/static/js/index.tsx 0% <ø> (ø) ⬆️
...ication/static/js/components/TableDetail/index.tsx 0% <ø> (ø) ⬆️
...ication/static/js/components/ProfilePage/index.tsx 100% <100%> (+1.51%) ⬆️
..._application/static/js/components/NavBar/index.tsx 100% <100%> (ø) ⬆️
...tion/static/js/components/ProfilePage/constants.ts 100% <100%> (ø) ⬆️
...n/static/js/components/common/Breadcrumb/index.tsx 100% <100%> (ø) ⬆️
...undsen_application/static/js/ducks/search/sagas.ts 69.9% <50%> (-1.1%) ⬇️
amundsen_application/config.py 100% <0%> (ø) ⬆️
amundsen_application/api/metadata/v0.py 77.62% <0%> (+2.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9ce3d3...0df3dd6. Read the comment docs.

@danwom danwom requested a review from ttannis January 9, 2020 01:00
@ttannis
Copy link
Contributor

ttannis commented Jan 13, 2020

Some additional UI comments:

  1. Now that the Avatar dropdown covers an important part of the new page layout, if it is an easy fix I think we should make sure it closes when someone selects a list item. edit: or navigates away from it.
  2. The list item in the Avatar dropdown has an unintended background color after clicking it navigating away.
  3. Nit: What do you think of also including design aspects from our new SearchPage (as ProfilePage is a resource page like TableDetail but also displays table list items like SearchPage), where we have a side panel with radio buttons instead of tabs for "Bookmarked", "Frequently Used", and "Owned"? I know we don't have an official design request for what this is supposed to look like, was there talk about moving away from tabs or am I just imagining that?
  4. Nit: Do you think it makes sense to change the number of results per page in this view or keep it at 6?

Copy link
Contributor

@ttannis ttannis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good but I haven't been able to verify the UI changes by building locally with our usual build script and I get some error about babel-polyfill. However when I checkout master that builds fine. I can't think of any reason why this would be the case since this makes no changes to our dependencies, but I can try to build master again after this is merged and see what happens in my environment.

.profile-avatar {
display: inline-block;
margin: 6px 16px 0 0;
}

.profile-details {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these styles no longer necessary/applicable because of header-section styles?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, these were all for the old layout.

@danwom
Copy link
Author

danwom commented Jan 21, 2020

1 & 2 should be fixed.
3: The layout in this PR is in accordance with design mocks. I think the tabbed layout is fine since we won't have any filters for this page.
4: I arbitrarily picked 6 items on this page as it was how many items would fit without scrolling on my screen. The recently the list items grew taller, but we also opened more space up near the top with this new design so 6 items still fit at my resolution.

@danwom
Copy link
Author

danwom commented Jan 21, 2020

I think this specific branch doesn't have the latest updates to the NPM packages, so it's not compatible with your current version of node. (should work with node 10 or lower)

@danwom danwom merged commit 82c36cb into master Jan 21, 2020
@ttannis
Copy link
Contributor

ttannis commented Jan 21, 2020

I think this specific branch doesn't have the latest updates to the NPM packages, so it's not compatible with your current version of node. (should work with node 10 or lower)

That must have been it. Master still building fine for me with these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants