-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added lineage item and lineage entities #90
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e8c85bf
added lineage item and lineage entities
allisonsuarez d7cf7d6
lint fixes
allisonsuarez 3c18437
added BAdge for badge list
allisonsuarez aeaa79d
small change to lineage schema
allisonsuarez 43b61e3
whitespace
allisonsuarez c21b731
rename
allisonsuarez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
# Copyright Contributors to the Amundsen project. | ||
# SPDX-License-Identifier: Apache-2.0 | ||
|
||
from typing import Optional, List | ||
|
||
from amundsen_common.models.table import Badge | ||
|
||
import attr | ||
from marshmallow_annotations.ext.attrs import AttrsSchema | ||
|
||
|
||
@attr.s(auto_attribs=True, kw_only=True) | ||
class LineageItem: | ||
key: str # down/upstream table/col/task key | ||
level: int # upstream/downstream distance from current resource | ||
source: str # database this resource is from | ||
badges: Optional[List[Badge]] | ||
usage: Optional[int] # statistic to sort lineage items by | ||
|
||
|
||
class LineageItemSchema(AttrsSchema): | ||
target = LineageItem | ||
register_as_scheme = True | ||
|
||
|
||
@attr.s(auto_attribs=True, kw_only=True) | ||
class Lineage: | ||
key: str # current table/col/task key | ||
direction: str # upstream/downstream | ||
depth: int # how many levels up/down 0 == all | ||
lineage_entities: List[LineageItem] # list of up/downstream entities | ||
|
||
|
||
class LineageSchema(AttrsSchema): | ||
target = Lineage | ||
register_as_scheme = True |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you share some examples on this class? e.g what are the badges and usage using here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just added the actual Badge class for badge list. Not sure what you mean by what the usage is using here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can change
usage
to be even more general and make it something likesorting_metric
or something like that, but usage seems like a natural way in which we would want to highlight more important upstream/downstream resources when you have lots of themThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My question is around how the metadata lineage entity connection will look like with badge and usage.