Skip to content

Commit

Permalink
Feedback 1
Browse files Browse the repository at this point in the history
Remove streams
Move fixtures to amundsen_common/tests
Stat as additional class, deprecate Statistics
  • Loading branch information
friendtocephalopods committed Sep 16, 2020
1 parent 013735c commit b7e75ef
Show file tree
Hide file tree
Showing 7 changed files with 36 additions and 602 deletions.
20 changes: 20 additions & 0 deletions amundsen_common/models/table.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,26 @@ class Meta:
register_as_scheme = True


@attr.s(auto_attribs=True, kw_only=True)
class Statistics:
"""
DEPRECATED. Use Stat
"""
stat_type: str
stat_val: Optional[str] = None
start_epoch: Optional[int] = None
end_epoch: Optional[int] = None


class StatisticsSchema(AttrsSchema):
"""
DEPRECATED. Use StatSchema
"""
class Meta:
target = Statistics
register_as_scheme = True


@attr.s(auto_attribs=True, kw_only=True)
class Stat:
stat_type: str
Expand Down
2 changes: 2 additions & 0 deletions amundsen_common/tests/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Copyright Contributors to the Amundsen project.
# SPDX-License-Identifier: Apache-2.0
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@


class Fixtures:
"""
These fixtures are useful for creating test objects. For an example usage, check out tests/tests/test_fixtures.py
"""
counter = 1000

@staticmethod
Expand Down
Loading

0 comments on commit b7e75ef

Please sign in to comment.