-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Atlas databuilder compatibility #1225
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
832064b
to
ffb5f21
Compare
cc @dechoma |
e0e4719
to
f8dea7a
Compare
69ae8d3
to
3f645b7
Compare
b578852
to
b471a60
Compare
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
#keepalive |
dechoma
reviewed
Jul 27, 2021
databuilder/databuilder/extractor/atlas_search_data_extractor.py
Outdated
Show resolved
Hide resolved
databuilder/databuilder/extractor/atlas_search_data_extractor.py
Outdated
Show resolved
Hide resolved
databuilder/databuilder/extractor/atlas_search_data_extractor.py
Outdated
Show resolved
Hide resolved
5e72f8a
to
227bac5
Compare
0c314fe
to
227bac5
Compare
dechoma
approved these changes
Jul 30, 2021
Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com>
… changes. Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com>
Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com>
Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com>
5f445b7
to
21f40cf
Compare
Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com>
Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com>
Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com>
zacr
pushed a commit
to SaltIO/amundsen
that referenced
this pull request
May 13, 2022
Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com>
hansadriaans
pushed a commit
to DataChefHQ/amundsen
that referenced
this pull request
Jun 30, 2022
Signed-off-by: mgorsk1 <gorskimariusz13@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:all
Related to all the project
area:common
From common folder
area:databuilder
From databuilder folder
area:metadata
From the metadata folder
keep fresh
Disables stalebot from closing an issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Introduces support between Atlas and majority of databuilder models.
The change was done with minimal amount of changes in the proxy itself, it's backwards compatible and unlocks both push and pull mode for ingesting data to Atlas:
New compatible models
Already supported models
Two models were temporarily excluded from this effort as they might require redesign in metadata AtlasProxy
Corresponding PR for introducing new Atlas Types
dwarszawski/amundsen-atlas-types#35
Tests
tbd
Documentation
CheckList
Make sure you have checked all steps below to ensure a timely review.