Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the OIDC docker images #224

Closed
jornh opened this issue Jan 11, 2020 · 2 comments
Closed

Document the OIDC docker images #224

jornh opened this issue Jan 11, 2020 · 2 comments
Labels
help wanted Extra attention is needed keep fresh Disables stalebot from closing an issue status:needs_votes Issue or bug fix that needs support from the community to be considered type:documentation A documentation improvement task

Comments

@jornh
Copy link
Contributor

jornh commented Jan 11, 2020

Document that Docker images exist (as part of the OIDC doc page?) which includes OIDC config for authentication

A follow up to amundsen-io/amundsenfrontendlibrary#352 and the similar PR in the amundsenmetadata repo

This is - also - a good first issue for someone who successfully managed to spin up Amundsen using these images.
@feng-tao feng-tao added the keep fresh Disables stalebot from closing an issue label Jan 13, 2020
@feng-tao feng-tao added the type:documentation A documentation improvement task label Jan 24, 2020
gabrielucelli pushed a commit to gabrielucelli/amundsen that referenced this issue Jan 28, 2020
@joaolcorreia @jinhyukchang
Deployment of non-production Amundsen on AWS ECS using aws-cli (amund…
9726156 
…sen-io#224)

Documentation on the deployment of non-production Amundsen on AWS ECS using aws-cli
@samshuster
Copy link
Contributor

not sure if the readme added here covers this story?
#260

@jornh
Copy link
Contributor Author

jornh commented Mar 26, 2020 •
edited
Loading

@samshuster apologies for the late reply.

Well, it does, partially, and it’s certainly a huge step towards better documentation of it. Thanks!

I do have a few thoughts I’d like input on:

  • Ideally I’d like documentation of how to use it with docker compose - for those not able to run K8s, though the bar for that certainly gets lowered with eg Docker Desktop evolution - even on a local windows box.

  • I think the page structure could be improved on. My preference would be top to bottom - like :

    • K8s (hopefully soon with description for more providers than Okta, via contributions)
    • docker images (we can start adding a placeholder heading asking for PRs),
    • manually aka @verdan’s original description

Context for suggestions above in this slack thread: https://amundsenworkspace.slack.com/archives/CGFBVT23V/p1582228133384300?thread_ts=1582148962.353900&channel=CGFBVT23V&message_ts=1582228133.384300

Thoughts?

@Golodhros Golodhros added help wanted Extra attention is needed status:needs_votes Issue or bug fix that needs support from the community to be considered labels May 29, 2020
gjxdxh pushed a commit to gjxdxh/amundsen that referenced this issue Dec 8, 2020
@jinhyukchang
Add query and chart on Dashboard (amundsen-io#224)
2cfa246 
* Add query and chart on Dashboard

* Update

* Increment version

* Update test case
benrifkind pushed a commit to benrifkind/amundsen that referenced this issue Dec 16, 2020
@Wonong
chore: Change deprecated function assertEquals to assertEqual (amunds…
f4ed92a 
…en-io#224)

Signed-off-by: Wonyeong Choi <ciwnyg0815@gmail.com>
dorianj pushed a commit to dorianj/amundsen that referenced this issue Apr 25, 2021
@joaolcorreia @jinhyukchang
Deployment of non-production Amundsen on AWS ECS using aws-cli (amund…
2ba6ab1 
…sen-io#224)

Documentation on the deployment of non-production Amundsen on AWS ECS using aws-cli
dorianj pushed a commit to dorianj/amundsen that referenced this issue Apr 25, 2021
@jinhyukchang
Add query and chart on Dashboard (amundsen-io#224)
99c4212 
* Add query and chart on Dashboard

* Update

* Increment version

* Update test case
dorianj pushed a commit to dorianj/amundsen that referenced this issue Apr 25, 2021
@Wonong
chore: Change deprecated function assertEquals to assertEqual (amunds…
1c8b177 
…en-io#224)

Signed-off-by: Wonyeong Choi <ciwnyg0815@gmail.com>
feng-tao pushed a commit that referenced this issue May 7, 2021
@joaolcorreia @jinhyukchang
Deployment of non-production Amundsen on AWS ECS using aws-cli (#224)
d132d7e 
Documentation on the deployment of non-production Amundsen on AWS ECS using aws-cli
feng-tao pushed a commit that referenced this issue May 7, 2021
@jinhyukchang
Add query and chart on Dashboard (#224)
907aea4 
* Add query and chart on Dashboard

* Update

* Increment version

* Update test case
feng-tao pushed a commit that referenced this issue May 7, 2021
@Wonong
chore: Change deprecated function assertEquals to assertEqual (#224)
5b66915 
Signed-off-by: Wonyeong Choi <ciwnyg0815@gmail.com>
dorianj pushed a commit to dorianj/amundsen that referenced this issue Sep 28, 2021
@jackolantern
Added models. (amundsen-io#224)
b2454e0 
* Added batch models
* Preview now uses batch
zacr pushed a commit to SaltIO/amundsen that referenced this issue May 13, 2022
@Wonong
chore: Change deprecated function assertEquals to assertEqual (amunds…
9612a90 
…en-io#224)

Signed-off-by: Wonyeong Choi <ciwnyg0815@gmail.com>
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this issue Jun 30, 2022
@jinhyukchang
Add query and chart on Dashboard (amundsen-io#224)
df5a297 
* Add query and chart on Dashboard

* Update

* Increment version

* Update test case
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this issue Jun 30, 2022
@joaolcorreia
Deployment of non-production Amundsen on AWS ECS using aws-cli (amund…
01d2c0a 
…sen-io#224)

Documentation on the deployment of non-production Amundsen on AWS ECS using aws-cli
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this issue Jun 30, 2022
@Wonong
chore: Change deprecated function assertEquals to assertEqual (amunds…
0f9acfc 
…en-io#224)

Signed-off-by: Wonyeong Choi <ciwnyg0815@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed keep fresh Disables stalebot from closing an issue status:needs_votes Issue or bug fix that needs support from the community to be considered type:documentation A documentation improvement task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Golodhros @jornh @samshuster @feng-tao