Skip to content

Commit

Permalink
Fixed a mistake in my prior documentation about oidc (happy to move t…
Browse files Browse the repository at this point in the history
…hat into a separate PR if you would like) (#263)

Added new table details page with badges
  • Loading branch information
samshuster authored Jan 31, 2020
1 parent 7b06829 commit 91a354a
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Please note that the mock images only served as demonstration purpose.

- **Table Detail Page**: Visualization of a Hive / Redshift table

![](docs/img/table_detail_page.png)
![](docs/img/table_detail_page_with_badges.png)

- **Column detail**: Visualization of columns of a Hive / Redshift table which includes an optional stats display

Expand Down
5 changes: 3 additions & 2 deletions docs/authentication/oidc.md
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,10 @@ Assumptions:
2. You need to register amundsen in okta as an app. More info [here](https://developer.okta.com/blog/2018/07/12/flask-tutorial-simple-user-registration-and-login).
But here are specific instructions for amundsen:
- At this time, I have only succesfully tested integration after ALL grants were checked.
- Set the Login redirect URIs to: http://amundsen-frontend/oidc_callback
- Set the Login redirect URIs to: `http://amundsen-frontend/oidc_callback`
- No need to set a logout redirect URI
- Set the Initiate login URI to: http://amundsen-frontend/oidc_callback
- Set the Initiate login URI to: `http://amundsen-frontend/`
(This is where okta will take you if users click on amundsen via okta landing page)
- Copy the Client ID and Client secret as you will need this later.
3. At present, there is no oidc build of the frontend. So you will need to build an oidc build yourself and upload it to, for example ECR, for use by k8s.
You can then specify which image you want to use as a property override for your helm install like so:
Expand Down
Binary file removed docs/img/table_detail_page.png
Binary file not shown.
Binary file added docs/img/table_detail_page_with_badges.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 91a354a

Please sign in to comment.