Correctly Utilize Cache in Tables Flyout (opensearch-project#1662)

* correctly check for cache on table flyout Signed-off-by: Sean Li <lnse@amazon.com> * skip start loading if fail Signed-off-by: Sean Li <lnse@amazon.com> --------- Signed-off-by: Sean Li <lnse@amazon.com>
amsiglan · Mar 29, 2024 · 3be2d39 · 3be2d39
1 parent 628f3fd
commit 3be2d39
Showing 1 changed file with 15 additions and 1 deletion.
diff --git a/...ts/datasources/components/manage/associated_objects/associated_objects_details_flyout.tsx b/...ts/datasources/components/manage/associated_objects/associated_objects_details_flyout.tsx
@@ -226,7 +226,21 @@ export const AssociatedObjectsDetailsFlyout = ({
 
   useEffect(() => {
     if (tableDetail && !tableDetail.columns) {
-      startLoading(datasourceName, tableDetail.database, tableDetail.name);
+      try {
+        const tables = CatalogCacheManager.getTable(
+          datasourceName,
+          tableDetail.database,
+          tableDetail.name
+        );
+        if (tables?.columns) {
+          setTableColumns(tables?.columns);
+        } else {
+          startLoading(datasourceName, tableDetail.database, tableDetail.name);
+        }
+      } catch (error) {
+        console.error(error);
+        setToast('Your cache is outdated, refresh databases and tables', 'warning');
+      }
     } else if (tableDetail && tableDetail.columns) {
       setTableColumns(tableDetail.columns);
     }