Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reserved identifier violation #2

Closed
elfring opened this issue Dec 22, 2013 · 4 comments
Closed

reserved identifier violation #2

elfring opened this issue Dec 22, 2013 · 4 comments

Comments

@elfring
Copy link

elfring commented Dec 22, 2013

I would like to point out that identifiers like "_FDINFO_H_" and "_FUNCS_H_" do not fit to the expected naming convention of the C language standard.
Would you like to adjust your selection for unique names?
@amscanne
Copy link
Owner

Interesting.

This is quite a common convention, but you learn something new every day I suppose :).

My read is that fdinfo_h would be okay?

@amscanne
Copy link
Owner

Damn GitHub formatting.

_fdinfo_h_

@elfring
Copy link
Author

elfring commented Dec 23, 2013

How do you think about to reuse also a name pattern like it is applied in other projects?

amrali pushed a commit to amrali/huptime that referenced this issue Dec 23, 2013
@amscanne @amrali
Fix header guards (fixes amscanne#2).
9451254 
TIL: Leading underscores followed by a capital letter is
actually a reserved identifier. This replaces the header
guards with a non-reserved identifier.
@elfring
Copy link
Author

elfring commented Dec 23, 2013

Thanks for your source code improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amscanne @elfring