Updated to 1.21.3 #75
Conversation
| @@ -75,7 +75,7 @@ else if (sender instanceof CommandContext<?> context) { | |||
| } | |||
|
|
|||
| public void sendMessage(Player player, String message) { | |||
| ((PlayerEntity) player.getPlayer()).sendMessage(toNative(mm(message))); | |||
| ((PlayerEntity) player.getPlayer()).sendMessage(toNative(mm(message)), false); | |||
There was a problem hiding this comment.
Will this break on older versions?
fabric/src/main/java/dev/amsam0/voicechatdiscord/FabricPlatform.java
Outdated
Show resolved
Hide resolved
paper/src/main/java/dev/amsam0/voicechatdiscord/PaperPlatform.java
Outdated
Show resolved
Hide resolved
|
the mod didn't work on fabric 1.21.3 and threw an exception |
|
What was the exception? I do not see the benefit of the paper changes and the fabric changes seem like they would have no effect. Edit: if getBukkitSender was removed, we can try to find a replacement. Bukkit.getEntity won't work iirc |
|
|
|
The overlay argument isn't optional? |
|
it looks like, it's not |
|
That won't work with earlier versions then. Either we need an alternative (maybe there's a sendMessage function in another type that doesn't have the overlay argument) or use reflection on older version |
|
@AlexDerProGamer Any chance of this PR being completed? If not, I can take over |
|
Currently I have no time to work on it. I think it would be best if you complete it. |
|
If you could complete this, that would be great. |
|
I do plan to complete this. I don't know when I'll have enough free time. I haven't forgotten about it - bugging me about it makes me less likely to work on it. |
|
Not trying to bug you. Just reminding you about it in case you did forget (there was no way to know). |
|
Thanks for the reminder. I am currently quite busy and this project is very low priority for my limited free time, mainly due to a lack of motivation (see the project status update). It may be a few weeks or up to a month until I get to it. |
|
Fortunately I was able to get this PR up and running for the meantime. |
|
Thank you for the initial work @AlexDerProGamer! I am now merging and will make a release |
I updated all dependecies to 1.21.3 and fixed the issue that appeared after doing so. I only tested the project as a fabric mod (not paper plugin) and I'm unsure if Bukkit.getEntity(nmsEntity.getUUID()); (nmsEntity.getBukkitSender(null); was removed) works.
I also didn't manage to run cargo build on the core directory because cmake threw an error, so i copied the natives from the 3.0.5 version (from modrinth) to my built test mod.
If there's something that I forgot or does not work correctly let me know!
Great mod/plugin btw, keep it up!