Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PaperPlatform#getEntityPosition fails when not in the main thread #56

Closed
DaddyRobLIVE opened this issue Jul 5, 2024 · 17 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@DaddyRobLIVE
Copy link

Describe the bug
Can't capture entity for voicechat due to Async processing

To Reproduce
Steps to reproduce the behavior:

  1. Install SparklyPaper - https://github.com/SparklyPower/SparklyPaper
  2. Install Simple Voicechat and DVC
  3. Do all the steps necessary
  4. Try to talk with someone
  5. See error - https://mclo.gs/ZpL6iBt

Expected behavior
I should be able to communicate without any issues but simple voice chat users can hear me but I can't hear them.

Screenshots
image

Logs
I don't think this is necessary but let me know if you really need it.

Versions (please complete the following information):

Additional context
None

@DaddyRobLIVE DaddyRobLIVE added the bug Something isn't working label Jul 5, 2024
@DaddyRobLIVE
Copy link
Author

I did more tests, I tried doing it with normal paper mc and it still has the error. One thing we did is I made a group and I joined there and we can both hear each other.

@amsam0
Copy link
Owner

amsam0 commented Jul 6, 2024

This used to be an issue a while ago, looks like it's back. Not sure when I will be able to work on a fix. What Minecraft version?

@amsam0 amsam0 closed this as completed in 8194338 Jul 6, 2024
@amsam0 amsam0 reopened this Jul 6, 2024
@amsam0
Copy link
Owner

amsam0 commented Jul 6, 2024

@DaddyRobLIVE Can you try using the nightly build at https://github.com/naturecodevoid/voicechat-discord/actions/runs/9817676120? Jars will be at the bottom

@DaddyRobLIVE
Copy link
Author

DaddyRobLIVE commented Jul 6, 2024 via email

@DaddyRobLIVE
Copy link
Author

DaddyRobLIVE commented Jul 6, 2024

image
Not yet fixed :/

please also make sure that it's compatible with offline mode, thank you so much!

@DaddyRobLIVE
Copy link
Author

image

@DaddyRobLIVE
Copy link
Author

This used to be an issue a while ago, looks like it's back. Not sure when I will be able to work on a fix. What Minecraft version?

The server is using Minecraft 1.20.6 SparklyPaper
I tried using the voice chat on Bedrock for Windows 1.21+

@amsam0
Copy link
Owner

amsam0 commented Jul 6, 2024

I will not be making any effort to support offline mode. The fix should've worked in 1.21 but since you're using 1.20.6, it didn't work. I will look into this further after confirming that it is a legitimate issue.

@amsam0 amsam0 changed the title Add compatibility to SparklyPaper getEntityPosition fails when not in the main thread Jul 6, 2024
@DaddyRobLIVE
Copy link
Author

Sure no problem with offline players. Just please try to fix it for version 1.20.6 thank you so much!

@DaddyRobLIVE
Copy link
Author

By the way, do you have a discord so that I can contact you privately? I have some proposal that might interest you.

@amsam0
Copy link
Owner

amsam0 commented Jul 6, 2024

My discord is on my GitHub profile - it's just @naturecodevoid

@amsam0 amsam0 changed the title getEntityPosition fails when not in the main thread PaperPlatform#getEntityPosition fails when not in the main thread Jul 6, 2024
@DaddyRobLIVE
Copy link
Author

Done, I've added you.

amsam0 added a commit that referenced this issue Jul 7, 2024
@amsam0
Copy link
Owner

amsam0 commented Jul 7, 2024

This nightly build should fix it. https://github.com/naturecodevoid/voicechat-discord/actions/runs/9829671893

@DaddyRobLIVE
Copy link
Author

I'll check it again, thanks for you hardwork.

@DaddyRobLIVE
Copy link
Author

Confirmed fixed!

@amsam0 amsam0 closed this as completed Jul 8, 2024
@BenGuined
Copy link

I still have that error come up even with the 1.21 build you posted. I can hear people using the discord bridge but they cannot hear me. any clue what is wrong
[18:51:34 ERROR]: [voicechat] Voice chat server error
java.lang.IllegalStateException: Asynchronous Chunk getEntities call!
at org.spigotmc.AsyncCatcher.catchOp(AsyncCatcher.java:15) ~[paper-1.20.6.jar:1.20.6-147-e41d44f]
at net.minecraft.server.level.ServerLevel.getEntities(ServerLevel.java:2582) ~[paper-1.20.6.jar:1.20.6-147-e41d44f]
at net.minecraft.server.level.ServerLevel.getEntity(ServerLevel.java:2088) ~[paper-1.20.6.jar:1.20.6-147-e41d44f]
at voicechat-discord-paper-3.0.0.jar/dev.naturecodevoid.voicechatdiscord.PaperPlatform.getEntityPosition(PaperPlatform.java:45) ~[voicechat-discord-paper-3.0.0.jar:?]
at voicechat-discord-paper-3.0.0.jar/dev.naturecodevoid.voicechatdiscord.DiscordBot.handlePacket(DiscordBot.java:285) ~[voicechat-discord-paper-3.0.0.jar:?]
at voicechat-bukkit-2.5.16 (1).jar/de.maxhenkel.voicechat.plugins.PluginManager.onListenerAudio(PluginManager.java:126) ~[voicechat-bukkit-2.5.16 (1).jar:?]
at voicechat-bukkit-2.5.16 (1).jar/de.maxhenkel.voicechat.voice.server.Server.sendSoundPacket(Server.java:383) ~[voicechat-bukkit-2.5.16 (1).jar:?]
at voicechat-bukkit-2.5.16 (1).jar/de.maxhenkel.voicechat.voice.server.Server.broadcast(Server.java:431) ~[voicechat-bukkit-2.5.16 (1).jar:?]
at voicechat-bukkit-2.5.16 (1).jar/de.maxhenkel.voicechat.voice.server.Server.processProximityPacket(Server.java:379) ~[voicechat-bukkit-2.5.16 (1).jar:?]
at voicechat-bukkit-2.5.16 (1).jar/de.maxhenkel.voicechat.voice.server.Server.processMicPacket(Server.java:316) ~[voicechat-bukkit-2.5.16 (1).jar:?]
at voicechat-bukkit-2.5.16 (1).jar/de.maxhenkel.voicechat.voice.server.Server.onMicPacket(Server.java:303) ~[voicechat-bukkit-2.5.16 (1).jar:?]
at voicechat-bukkit-2.5.16 (1).jar/de.maxhenkel.voicechat.voice.server.Server$ProcessThread.run(Server.java:269) ~[voicechat-bukkit-2.5.16 (1).jar:?]
[18:51:34 ERROR]: Thread VoiceChatPacketProcessingThread failed main thread check: Chunk getEntities call
java.lang.Throwable: null
at org.spigotmc.AsyncCatcher.catchOp(AsyncCatcher.java:14) ~[paper-1.20.6.jar:1.20.6-147-e41d44f]
at net.minecraft.server.level.ServerLevel.getEntities(ServerLevel.java:2582) ~[paper-1.20.6.jar:1.20.6-147-e41d44f]
at net.minecraft.server.level.ServerLevel.getEntity(ServerLevel.java:2088) ~[paper-1.20.6.jar:1.20.6-147-e41d44f]
at voicechat-discord-paper-3.0.0.jar/dev.naturecodevoid.voicechatdiscord.PaperPlatform.getEntityPosition(PaperPlatform.java:45) ~[voicechat-discord-paper-3.0.0.jar:?]
at voicechat-discord-paper-3.0.0.jar/dev.naturecodevoid.voicechatdiscord.DiscordBot.handlePacket(DiscordBot.java:285) ~[voicechat-discord-paper-3.0.0.jar:?]
at voicechat-bukkit-2.5.16 (1).jar/de.maxhenkel.voicechat.plugins.PluginManager.onListenerAudio(PluginManager.java:126) ~[voicechat-bukkit-2.5.16 (1).jar:?]
at voicechat-bukkit-2.5.16 (1).jar/de.maxhenkel.voicechat.voice.server.Server.sendSoundPacket(Server.java:383) ~[voicechat-bukkit-2.5.16 (1).jar:?]
at voicechat-bukkit-2.5.16 (1).jar/de.maxhenkel.voicechat.voice.server.Server.broadcast(Server.java:431) ~[voicechat-bukkit-2.5.16 (1).jar:?]
at voicechat-bukkit-2.5.16 (1).jar/de.maxhenkel.voicechat.voice.server.Server.processProximityPacket(Server.java:379) ~[voicechat-bukkit-2.5.16 (1).jar:?]
at voicechat-bukkit-2.5.16 (1).jar/de.maxhenkel.voicechat.voice.server.Server.processMicPacket(Server.java:316) ~[voicechat-bukkit-2.5.16 (1).jar:?]
at voicechat-bukkit-2.5.16 (1).jar/de.maxhenkel.voicechat.voice.server.Server.onMicPacket(Server.java:303) ~[voicechat-bukkit-2.5.16 (1).jar:?]
at voicechat-bukkit-2.5.16 (1).jar/de.maxhenkel.voicechat.voice.server.Server$ProcessThread.run(Server.java:269) ~[voicechat-bukkit-2.5.16 (1).jar:?]

@amsam0
Copy link
Owner

amsam0 commented Jul 8, 2024

You are not using the build posted. If it still doesn't work just wait for 3.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants