Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ActivityImage MessageCard value #19

Closed
jamieastley opened this issue Feb 28, 2021 · 0 comments · Fixed by #24
Closed

Fix ActivityImage MessageCard value #19

jamieastley opened this issue Feb 28, 2021 · 0 comments · Fixed by #24
Assignees
@jamieastley
Labels
bug Something isn't working
Milestone
2.0.0

Comments

@jamieastley
Copy link
Collaborator

Value is currently being set from the config.AppImageURL, which by default uses the $BITRISE_APP_SLUG env var as it's value, and this does not of course display any image within the Teams message.

Should use the config.sectionHeaderImage value instead.
@jamieastley jamieastley added the bug Something isn't working label Feb 28, 2021
@jamieastley jamieastley added this to the 2.0.0 milestone Feb 28, 2021
@jamieastley jamieastley self-assigned this Feb 28, 2021
@jamieastley jamieastley changed the title Fix ActivityImage MessageCard value Fix ActivityImage MessageCard value Feb 28, 2021
jamieastley added a commit to jamieastley/bitrise-step-microsoft-teams-integration that referenced this issue Feb 28, 2021
@jamieastley
[amrfarid140#19] fix ActivityImage in message card
add1902 
- removed redundant `AppImageURL` input
- use `SectionHeaderImage` input for image
- fix test
@jamieastley jamieastley mentioned this issue Feb 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamieastley jamieastley

Labels
bug Something isn't working
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

[#19] fix ActivityImage in message card jamieastley/bitrise-step-microsoft-teams-integration
1 participant
@jamieastley